Guarantee invokation of complete()
#5598
Conversation
Transition end event isn't reliable (browser may not fire it, or delay its firing until next transition, in many circumstances, read more in related issue twbs#5462 twbs#5462). In order to guarantee proper inner state of `Collapse` object (especially `Collapse#transitioning`, because its invalid state will block all successive transitions) additional callback invokation is added with `setTimeout()`. Timeout value for `setTimeout()` is equal to transition time from `component-animation.less` - I cannot find a better solution for now.
|
Your patch causes unexpected behavior when setTimeout executes the complete function. It relies on the startEvent parameter of the calling transition function, which seems to be unreliable at times, especially when clicking on the collapse toggle several times in a row. The problem lies in the complete function thinking that the startEvent.type is 'show' when it's actually 'hide' since the complete function is called a few times. To fix this problem, simply pass in the original startEvent as a parameter to the complete function. Here's the gist: https://gist.github.com/4121673 I'm also passing in the Collapse context, which I use instead of the 'that' variable. |
|
honestly - i want to rip all css transitions out of bootstrap (maybe for 3.0.0). they are a complete mess of a spec, and just a piece of shit in general. which is sad. :( but not a good thing to build a solid product on. |
Transition end event isn't reliable (browser may not fire it, or delay its firing until next transition, in many circumstances, read more in related issue #5462 #5462).
In order to guarantee proper inner state of
Collapseobject (especiallyCollapse#transitioning, because its invalid state will block all successive transitions) additional callback invokation is added withsetTimeout().Timeout value for
setTimeout()should be equal to transition time fromcomponent-animation.less- I cannot find a better solution for now.