Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix position of focused search in inverse navbar #4859

Closed
wants to merge 1 commit into from
Closed

fix position of focused search in inverse navbar #4859

wants to merge 1 commit into from

Conversation

moesalih
Copy link

When the search field in inverse navbar is focused, a small jump is size
is noticable. This is due to changing the border and padding which is
unnecessary.

When the search field in inverse navbar is focused, a small jump is size
is noticable. This is due to changing the border and padding which is
unnecessary.
@travisbot
Copy link

This pull request passes (merged 5e3d94b into afd9312).

@moesalih
Copy link
Author

The issue can be seen in the bootstrap docs (http://twitter.github.com/bootstrap/components.html#navbar) under the Inverted variation section. Just select the search field and unselect it and you'll see the 1-pixel jump in size.

@mdo
Copy link
Member

mdo commented Sep 1, 2012

I see no jumping. What browser?

@moesalih
Copy link
Author

moesalih commented Sep 1, 2012

I tested latest Firefox and Chrome and It happens in both. It's a subtle 1-pixel increase in size, and just looks a little weird.

If you want to see what this fix does, just disable the border and padding properties in the developer tools, and select/unselect the field, you'll see that it looks a little better.

@mdo
Copy link
Member

mdo commented Sep 3, 2012

The focused state is removing the border and increasing the padding, by 1px on all sides. It's an intentional change and one we'll keep for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants