Add popover / tooltip destroy method #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Jones-Gill
added a commit
to Chris-Jones-Gill/bootstrap
that referenced
this pull request
Jun 19, 2012
Add js tooltip function so a tooltip can be called without using rel= Update tooltip html to reflect new js function Include changes from twitter/bootstrap issue twbs#3888 Include changes from twitter/bootstrap issue twbs#3885 Include changes from twitter/bootstrap issue twbs#3884 Include changes from twitter/bootstrap issue twbs#3880 Include changes from twitter/bootstrap issue twbs#3878 Include changes from twitter/bootstrap issue twbs#3876 Include changes from twitter/bootstrap issue twbs#3875
| @@ -235,6 +235,12 @@ | |||
| this[this.tip().hasClass('in') ? 'hide' : 'show']() | |||
| } | |||
|
|
|||
| , destroy: function () { | |||
| var $e = this.$element | |||
There was a problem hiding this comment.
could you change this to this.$element.off().removeData('tooltip')
fat
added a commit
that referenced
this pull request
Jun 20, 2012
Add popover / tooltip destroy method
|
This is going to break code where the element has other events defined. If I say $foo.tooltip('destroy'), I don't want other events that are tied to the element to be removed. |
|
@nathanbowser Yea, I was thinking about that too. I'll submit a pull request fixing it unless @fat just wants to do it. |
lookfirst
added a commit
to lookfirst/bootstrap
that referenced
this pull request
Jul 16, 2012
lookfirst
added a commit
to lookfirst/bootstrap
that referenced
this pull request
Jul 20, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to my comments on issue #3453
includes simple implementation, docs, a small random fix to docs and unit tests.