Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples #38182

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers examples #38182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
392c3ed
Improve docs on Modals, Alerts, Offcanvas and Toasts close triggers e…
hannahiss Mar 7, 2023
77e2a94
Merge branch 'main' into main-his-btn-close-triggers
hannahiss Mar 7, 2023
51058a3
Update site/layouts/shortcodes/js-dismiss.html
mdo Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions site/layouts/shortcodes/js-dismiss.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

{{- $name := .Get 0 -}}

Dismissal can be achieved with the `data` attribute on a button **within the {{ $name }}** as demonstrated below:
Dismissal can be achieved with the `data-bs-dismiss` attribute on a button **within the {{ $name }}** as demonstrated below:

```html
<button type="button" class="btn-close" data-bs-dismiss="{{ $name }}" aria-label="Close"></button>
```

or on a button **outside the {{ $name }}** using the `data-bs-target` as demonstrated below:
or on a button **outside the {{ $name }}** using the additional `data-bs-target` as demonstrated below:

```html
<button type="button" class="btn-close" data-bs-dismiss="{{ $name }}" data-bs-target="#my-{{ $name }}" aria-label="Close"></button>
Expand Down