Add jquery.ready hook after defining plugin, to avoid breakage with modernizr/yepnope #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed with modernizr/yepnope See https://gist.github.com/1258742 for an example, which results in the error "TypeError: Object has no method 'dropdown' at bootstrap-dropdown.js line 31" It looks like in these circumstances, the functions hooked into jquery.ready get run immediately, and so applying the dropdown behavior to specific elements before defining the 'dropdown' method causes breakage.
fat
added a commit
that referenced
this pull request
Oct 3, 2011
Add jquery.ready hook after defining plugin, to avoid breakage with modernizr/yepnope
|
weird, thanks! |
|
Yeah, I understand that in some cases the DOM can end up being ready before asynchronously-loaded scripts even get executed, in which case jQuery will presumably run new |
|
yeah -- you'd think jquery would push them to the event loop even in that case, but i guess not :) |
This was referenced Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://gist.github.com/1258742 for an example, which results in the error:
"TypeError: Object has no method 'dropdown' at bootstrap-dropdown.js line 31"
It looks like in these circumstances, the functions hooked into
jquery.ready get run immediately, and so applying the dropdown
behavior to specific elements before defining the 'dropdown' method
causes breakage.
-Steve