Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to carousel crossfade docs about bg color #35587

Merged
merged 5 commits into from
Dec 23, 2021
Merged

Add note to carousel crossfade docs about bg color #35587

merged 5 commits into from
Dec 23, 2021

Conversation

XhmikosR
Copy link
Member

Fixes #35181

@rabuckley
Copy link
Contributor

I think "you may way to" should instead be "you may want to"

@XhmikosR XhmikosR marked this pull request as ready for review December 23, 2021 06:44
ffoodd
ffoodd approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@XhmikosR XhmikosR merged commit deb8e3f into main Dec 23, 2021
@XhmikosR XhmikosR deleted the carousel-crossfade-text-note branch December 23, 2021 12:38
XhmikosR added a commit that referenced this pull request Jan 3, 2022
@XhmikosR
Add note to carousel crossfade docs about bg color (#35587)
3508ce6
XhmikosR added a commit that referenced this pull request Jan 4, 2022
@XhmikosR
Add note to carousel crossfade docs about bg color (#35587)
bee3847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffoodd ffoodd ffoodd approved these changes

Assignees
No one assigned
Labels
backport-to-v4 docs v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel fade in fade out text transition is not smooth (v5.1.3)
4 participants
@XhmikosR @rabuckley @ffoodd @mdo