-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separator for table direct children #34861
Conversation
I feel like the new code is actually simpler somehow? I don't mind it as the path forward. Utilities could work, but ideally stuff like this works out of the box IMO. Maybe I made tables too opinionated in v5 😬 |
So what about this 😄? Do we stick with the |
Nah, I think since v5 you reduce 2 to 1. But I don't know why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ffoodd I think we stick with the 2px still. Let's ship it!
Fixes #34732, closes #34764 as a replacement, basically refactoring the evolution from v4 instead of adding old code.
The main culprit here is getting back to a
2px
border, since for whatever reason a1px
border is hidden behind cells borders. As pointed out by @adityadees, a1.1
multiplicator would be enough, but feels like a magic number to me.IMHO @mdo we'd better recommend to use our border utilities (eg.
.border-dark
in the initial issue, as in this dedicated CodePen) rather than fixing this. Any thought?Demo on CodePen.