Move get element functionality to a helper #33327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
from
610338c to
7c062af
Compare
GeoSot
changed the title
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
2 times, most recently
from
5330190 to
cc58af5
Compare
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
2 times, most recently
from
ac0d09e to
5ccda43
Compare
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
from
5ccda43 to
f9815b7
Compare
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
from
f9815b7 to
ae16134
Compare
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
3 times, most recently
from
48f7b45 to
54c25be
Compare
XhmikosR
changed the title
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
2 times, most recently
from
4a4d9d2 to
4ce3091
Compare
alpadev
reviewed
May 13, 2021
GeoSot
force-pushed
the
get-element-vrom-variable-obj
branch
from
4ce3091 to
976d762
Compare
alpadev
approved these changes
May 13, 2021
XhmikosR
approved these changes
May 13, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking around on js components I found out many checks, different expressed but with same purpose.
Some of them are trying to parse string to element, others, jQuery element to js simple nodeElement etc
With this Pr, I am trying to give a standard way to parse an element
So this pr:
getElementhelper that tries to parse an argument to element or nullisElementto make explicit checks and return Boolean