Carousel: use buttons, not links, for prev/next controls (backport to v4) #33165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as the JS tests in v4 are far more extensive, but none of them related to the prev/next controls, left them as they are |
mdo
approved these changes
Mar 11, 2021
Carousel: use buttons, not links, for prev/next controls
XhmikosR
force-pushed
the
patrickhlauke-carousel-v4
branch
from
897d32c to
2faebae
Compare
This was referenced May 19, 2022
This was referenced Sep 23, 2024
This was referenced Sep 30, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #32627