Tooltip/popover - change the default value for fallbackPlacements
#32437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Dec 11, 2020
patrickhlauke
previously requested changes
Dec 14, 2020
The default value for fallbackPlacements is [oppositePlacement] in Popper (That does not flip the element if there is not enough space for placing)
rohit2sharma95
force-pushed
the
rohit/main/fallbackPlacements-option
branch
from
7296378 to
d08aec3
Compare
XhmikosR
changed the title
fallbackPlacements
|
Should we mention this in migration notes @rohit2sharma95 ? |
|
Mentioning it would be better because now the default fallback placement has been changed. |
rohit2sharma95
force-pushed
the
rohit/main/fallbackPlacements-option
branch
from
620f982 to
87b0286
Compare
XhmikosR
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for
fallbackPlacementshas been changed already in #32405 and here are the remaining things to do.What this PR does:
nullfromfallbackPlacementstypesfallbackPlacementsWhy to remove
nullfromfallbackPlacementstypes and keep array:'flip'that can be achieved by passing the single value in the array, like —[oppositePlacement]. Keepingnullalso sets thefallbackPlacementsto[oppositePlacement](Default value in Popper)['top', 'right', 'bottom', 'left']) fallback options so that tooltip/popover can be placed to another side even if the opposite placement doesn't fit.BTW #32384 is caused because the default value for
fallbackPlacementsis[oppositePlacement]in Popper and if you check the issue on a bit larger screen, it is not reproduced.As per Popper's documentation:
All SS are from v5.0.0-beta1
This PR probably completes the third todo of #32354: Update docs after #32405
Preview: https://deploy-preview-32437--twbs-bootstrap.netlify.app/docs/5.0/components/popovers/#example