tooltip/popover: add a customClass option

[remeika]

Please squash before merging

Fixes #19415

Add extra classes to Tooltips and Popovers using the additionalClasses option, using $.addClass() behind the scenes.

Details:

• Additional classes are evaluated and added every time the show() command is run. This should be idempotent, and allows the class list to be updated every time the component is shown.
• New classes are added after the component template is hydrated in the DOM; if classes are added to a custom template and using additionalClasses, both will show up.

Questions I still have:

• I targeted this release at the 4.X branch. I am not sure if I did the right thing there, rather than basing my work off main.
• It looks like the file size of bootstrap.bundle.js has been locked in place: adding any additional code causes the build pipeline to fail. I'm wondering what course of action an individual contributor should take in this situation: Is the 4.X branch feature-locked? Should I try to delete some code elsewhere to try to squeeze under the limit? Should I just raise the limit?

[XhmikosR]

Thanks for the PR!

That being said, we always target the main branch first and then we backport anything if deemed necessary. That being said, since the tests differ, we'd need a v4-dev patch anyway.

But we'd need a patch for the main branch anyway. About bundlewatch, leave that to us, we'll update the file before merging.

[Johann-S]

Nice work @remeika! 👍

Some changes to do but not so much

[Johann-S]

I would prefer a parameter called : customClass which would allow an array of string or a function it would be better if someone wants to add a lot of classes

[remeika]

@Johann-S As this PR stands now, the additionalClasses property is a logic-less wrapper around jQuery.addClass(). As of jquery 3.3, addClass() does accept an array of classes. So my initial thinking was that in Bootstrap 4.X, we guarantee that a string or function are valid inputs (although passing in an array will work in environments with a modern version of jQuery), and then in Bootstrap 5 we could rely on a more modern version of jQuery. But I just checked package.json on the main branch, and jQuery is no longer listed as a peer dependency. Will Bootstrap 5 not depend on jQuery? If so I will definitely change my strategy.

[Johann-S]

in v4 we can stay like you did, just the renaming (additionalClasses -> customClass) but since v5 is intended to work without jQuery I would prefer an array and a function

[cankitm]

But we'd need a patch for the main branch anyway. About bundlewatch, leave that to us, we'll update the file before merging.

@XhmikosR @Johann-S Can I pick the patch for main branch?

[XhmikosR]

My only concern is that people might ask for the ability add custom classes in all components. So, shouldn't we have a helper function and add this functionality in all components?

[Johann-S]

yup you're right it will be asked for sure.

But currently our code architecture doesn't allow to have one helper shared across our components because we don't use inheritance

[XhmikosR]

Maybe we should wait until this can be applied to all components? I feel like it's sort of incomplete if we don't add this for all components

[Johann-S]

it's a point of view, or we can add it when folks ask for it 🤷

[XhmikosR]

@remeika can you make a PR for main too please?

[XhmikosR]

@Johann-S LGTY?

@rohit2sharma95 if we merge this, can you make a PR against main later please? 🙂

[rohit2sharma95]

Okay sure 👍 @XhmikosR