Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap home content in <main> & use <section> #31580

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Wrap home content in <main> & use <section> #31580

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
757f0a8
docs(home): wrap all content in <main> & use <section>
ffoodd Sep 2, 2020
09cb0ea
Merge branch 'main' into main-fod-docs-home-accessibility
patrickhlauke Sep 4, 2020
a01ba9f
Merge branch 'main' into main-fod-docs-home-accessibility
XhmikosR Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions site/layouts/_default/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@

{{ partial "docs-navbar" . }}

{{ partial "home/masthead" . }}
{{ partial "home/masthead-followup" . }}
<main>
{{ partial "home/masthead" . }}
{{ partial "home/masthead-followup" . }}
</main>

{{ .Content }}

Expand Down
16 changes: 8 additions & 8 deletions site/layouts/partials/home/masthead-followup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="container masthead-followup px-4 px-md-3">
<div class="row mb-5 pb-md-4 align-items-center">
<section class="row mb-5 pb-md-4 align-items-center">
<div class="col-md-5">
<div class="masthead-followup-icon d-inline-block mb-2 text-white bg-success">
{{ partial "icons/code.svg" (dict "width" "32" "height" "32") }}
Expand All @@ -15,9 +15,9 @@ <h2 class="display-5 font-weight-normal">Installation</h2>
{{ highlight "npm install bootstrap" "sh" "" }}
{{ highlight (printf ("gem install bootstrap -v %s") .Site.Params.current_ruby_version) "sh" "" }}
</div>
</div>
</section>

<div class="row mb-5 pb-md-4 align-items-center">
<section class="row mb-5 pb-md-4 align-items-center">
<div class="col-md-5">
<div class="masthead-followup-icon d-inline-block mb-2 text-white bg-primary">
{{ partial "icons/cloud-fill.svg" (dict "width" "32" "height" "32") }}
Expand All @@ -39,9 +39,9 @@ <h2 class="display-5 font-weight-normal">BootstrapCDN</h2>
<script src="%s" integrity=%q crossorigin="anonymous"></script>
`) .Site.Params.cdn.popper (.Site.Params.cdn.popper_hash | safeHTMLAttr) .Site.Params.cdn.js (.Site.Params.cdn.js_hash | safeHTMLAttr)) "html" "" }}
</div>
</div>
</section>

<div class="row mb-5 pb-md-4 align-items-center">
<section class="row mb-5 pb-md-4 align-items-center">
<div class="col-md-5">
<div class="masthead-followup-icon d-inline-block mb-2 text-white bd-bg-purple-bright">
{{ partial "icons/circle-square.svg" (dict "width" "32" "height" "32") }}
Expand All @@ -61,9 +61,9 @@ <h2 class="display-5 font-weight-normal">Bootstrap Icons</h2>
src="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-icons.png"
alt="Bootstrap Icons" width="966" height="600" loading="lazy">
</div>
</div>
</section>

<div class="row mb-5 pb-md-4 align-items-center">
<section class="row mb-5 pb-md-4 align-items-center">
<div class="col-md-5">
<div class="masthead-followup-icon d-inline-block mb-2 text-white bg-danger">
{{ partial "icons/droplet-fill.svg" (dict "width" "32" "height" "32") }}
Expand All @@ -83,5 +83,5 @@ <h2 class="display-5 font-weight-normal">Official Themes</h2>
src="/docs/{{ .Site.Params.docs_version }}/assets/img/bootstrap-themes.png"
alt="Bootstrap Icons" width="700" height="500" loading="lazy">
</div>
</div>
</section>
</div>
4 changes: 2 additions & 2 deletions site/layouts/partials/home/masthead.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<main class="bd-masthead mb-3 mb-md-5" id="content">
<div class="bd-masthead mb-3 mb-md-5" id="content">
<div class="container px-4 px-md-3">
<div class="row align-items-lg-center">
<div class="col-8 mx-auto col-md-4 order-md-2 col-lg-5">
Expand All @@ -23,4 +23,4 @@ <h1 class="mb-3">Build fast, responsive sites with Bootstrap</h1>
</div>
{{ partial "ads.html" . }}
</div>
</main>
</div>