-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add border width utility #31484
Add border width utility #31484
Conversation
I have added the border-width utility and a variable for handle the sizes |
I think we can leave the |
Okay, What do you mean by documentation? |
Explain how these utilities need to be used on our documentation site. You'll probably need to edit this file: https://github.com/twbs/bootstrap/blob/main/site/content/docs/5.0/utilities/borders.md |
Thanksss. I am going to work on the docs |
wooow the documentation in bootstrap is beatiful. I am learning a lot of front with this project |
@MartijnCuppens can I do some more por bootstrap? I want to contribute more to this project |
Would it not be better to have these in rem units rather than px units? |
We don't do that for borders. Browsers will always render them in px, so if the default browser font size is changed, the borders could be blurred because they are for example 1.25px. @MauricioHernanCabrera, could you rebase this branch, it contains lots of unrelated changes? |
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. ping @twbs/css-review for second opinion
@mdo WDYT? |
Can we get a mention on the |
I'm not sure the example is right, we should probably add margin right in the examples? |
okasss, I'm going to work on that |
Co-authored-by: Martijn Cuppens <[email protected]>
Co-authored-by: XhmikosR <[email protected]> Co-authored-by: Martijn Cuppens <[email protected]>
I added border-width utility. it was a request #31299
Example
Fixes #31299
Demo: https://deploy-preview-31484--twbs-bootstrap.netlify.app/docs/5.0/utilities/borders/#border-width