Minor JS consistency changes #31212
Merged
Minor JS consistency changes #31212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
reviewed
Jun 30, 2020
| delete dataAttributes[dataAttr] | ||
| } | ||
| }) | ||
| Object.keys(dataAttributes).forEach(dataAttr => { |
There was a problem hiding this comment.
I would keep the indent because we chain calls here
There was a problem hiding this comment.
There's not another instance we break after Object.keys in the whole codebase...
There was a problem hiding this comment.
so maybe we should apply that to the other calls of Object.keys, shorter line is always better for the reading
There was a problem hiding this comment.
I think it's fine here.
There was a problem hiding this comment.
FYI:
Search "Object.keys" (11 hits in 7 files)
C:\Users\xmr\Desktop\bootstrap\build\build-plugins.js (1 hit)
Line 180: await Promise.all(Object.keys(bsPlugins).map(plugin => build(plugin)))
C:\Users\xmr\Desktop\bootstrap\js\src\dom\event-handler.js (5 hits)
Line 129: const uidEventList = Object.keys(events)
Line 212: Object.keys(storeElementEvent).forEach(handlerKey => {
Line 251: Object.keys(events).forEach(elementEvent => {
Line 257: Object.keys(storeElementEvent).forEach(keyHandlers => {
Line 304: Object.keys(args).forEach(key => {
C:\Users\xmr\Desktop\bootstrap\js\src\dom\manipulator.js (1 hit)
Line 50: Object.keys(attributes).forEach(key => {
C:\Users\xmr\Desktop\bootstrap\js\src\tooltip.js (1 hit)
Line 679: Object.keys(dataAttributes)
C:\Users\xmr\Desktop\bootstrap\js\src\util\index.js (1 hit)
Line 113: Object.keys(configTypes).forEach(property => {
C:\Users\xmr\Desktop\bootstrap\js\src\util\sanitizer.js (1 hit)
Line 103: const allowlistKeys = Object.keys(allowList)
C:\Users\xmr\Desktop\bootstrap\js\tests\browsers.js (1 hit)
Line 63: const browsersKeys = Object.keys(browsers)
So, it's basically only this instance and also we don't enforce it, which TBH is better since this is really just a trivial thing :)
bardiharborow
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.