Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: clarify that pointer events classes don't affect keyboard interaction #31134

Merged
merged 5 commits into from
Jul 3, 2020
Merged

Docs: clarify that pointer events classes don't affect keyboard interaction #31134

merged 5 commits into from
Jul 3, 2020

Conversation

patrickhlauke
Copy link
Member

No description provided.

mdo
mdo reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this amount of content, I feel like it shouldn't be a warning. Any objections to making it standard body text here?

@patrickhlauke
Copy link
Member Author

i was tending towards a warning mainly because (anecdotally) it's non-obvious to many devs who somehow just design for mouse users

@patrickhlauke patrickhlauke merged commit 386f9e3 into main Jul 3, 2020
@patrickhlauke patrickhlauke deleted the v5-docs-interactions-pe branch July 3, 2020 11:23
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@patrickhlauke @olsza
Docs: clarify that pointer events classes don't affect keyboard inter…
ac54dce 
…action (twbs#31134)

* Docs: clarify that pointer events classes don't affect keyboard interaction

* Neutralise example links that are `pe-none`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo left review comments

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
docs no-backport-to-v4 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhlauke @mdo @MartijnCuppens