Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modal: fix scrollable modal-body #31096

Closed
wants to merge 1 commit into from
Closed

modal: fix scrollable modal-body #31096

wants to merge 1 commit into from

Conversation

Hiws
Copy link
Contributor

@Hiws Hiws commented Jun 18, 2020

Implements the suggested fix to make .modal-body scrollable when the content would otherwise overflow the viewport.

Closes: #31084

@Hiws Hiws requested a review from a team as a code owner June 18, 2020 11:42
@ysds
Copy link
Member

ysds commented Jun 23, 2020 •
edited
Loading

I'll see later.

BTW, it is intentional to use 100% instead of 100vh. 100vh doesn't avoid the address/toolbar of mobile browsers.

@ysds ysds mentioned this pull request Jun 23, 2020
Merged
@Hiws
Copy link
Contributor Author

Hiws commented Jun 23, 2020

BTW, it is intentional to use 100% instead of 100vh. 100vh doesn't avoid the address/toolbar of mobile browsers.

Oh, i had no idea.
Thanks for the tip :)

@Hiws Hiws closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

modal dialog scrollable isn't working in v5 alpha, need some css improvement
3 participants
@Hiws @ysds @Johann-S