-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: rename form checks page to "Checks / radios" #31090
Conversation
it's not immediately obvious that "checks" includes information about both checkboxes and radio buttons. while "checks / radios" is also still not perfect (as honestly even I didn't quite grok that "checks" meant checkboxes), it should make it slightly more obvious nonetheless
d9870b2
to
e0cfc3f
Compare
(btw not sure if there's anything more that needs to be done for such a fundamental restructure...forgive my naive approach here) |
I'm also in favor of renaming checks to checkboxes (and also Btw, the link in the sidemenu is broken in this PR |
I wasn't sure how to resolve this in terms of having it shorter in the sidebar ("Checks / radios") but still have the title longer on the page itself ("Checks and radios"). I tried to work out how the "Browsers & devices"/"Browsers and devices" page does it, but to no avail. I think the other changes (actually changing the classnames etc) may be a bit more fundamental...in this PR I'm really just after some clarity for the docs themselves, as it's unintuitive that "Checks" covers both checkboxes and radio buttons (though yes, they still use the same classname) |
I'd like to leave the class name as-is to keep v4 and v5 close. Every rename means more work for folks to upgrade. I'm okay to change the name of the page, though. |
any clue on how to end up with having the link in the sidebar say "Checks / radios", the URL be checks-radios, the title in full be "Checks and radios"? (similar to what "Browsers & devices" does) am i missing some key location/file that helps with this mapping/connection? |
In
Hugo's urlize function is used as "mapping"
|
see if "&" works better than "/" (without need for further tweaks)
while not a fan, i've fixed it by using |
any clue why the two checks for Docs keep failing for this PR? |
@patrickhlauke There's a link somewhere pointing to |
@ffoodd aha, it helps when i look at the actual details for the "docs (pull_request)" (as the "docs (push)" one was just cryptic). found it... |
* Docs: rename form checks page to "Checks / radios" it's not immediately obvious that "checks" includes information about both checkboxes and radio buttons. while "checks / radios" is also still not perfect (as honestly even I didn't quite grok that "checks" meant checkboxes), it should make it slightly more obvious nonetheless
it's not immediately obvious that "checks" includes information about both checkboxes and radio buttons. while "checks / radios" is also still not perfect (as honestly even I didn't quite grok that "checks" meant checkboxes), it should make it slightly more obvious nonetheless
Preview: https://deploy-preview-31090--twbs-bootstrap.netlify.app/docs/5.0/forms/checks-radios/