-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reboot's th
updates: Inherit font-weight: bold
that comes from user agent stylesheets.
#30781
Conversation
I like the default bold font weight which makes a visual difference between the table cells. We could |
Hmm, yep but I think the default needs to be consistent through all browsers. |
Agreed, every browser applies I'm not sure about the interest of allowing this through a variable, TBH: it's pretty easy to either apply a utility or to override those styles. We'd be adding code for something that hasn't been requested. |
Yep. I think if bs users needs to style th, they should do this on the html element, and not class. Seems "natural" I think :) |
Using a Sass variables is not easier than editing Furthermore, if one uses this to unset |
"Using a Sass variables is not easier than editing _reboot.scss" actually it is and the thing is, I think we don't want to force our users to edit any of our bootstrap core code. "how are they supposed to make them distinguishable", yep. I think the possibilities are endless here: a simple border under Imho, we should give our user this option, of not leaving browsers manage this and not trough |
It's a bit clearer, thanks for your patience :) I'm still not sure about this, since it could too easily give undistinguishable @MartijnCuppens feel free to approve or discuss! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in favor of this since the font-weight stays bold. We could easily backport this to v4 as well I'd think. Thoughts @MartijnCuppens?
I marked this for backport, but you guys decide if it's considered a breaking changes. The next v4 release is supposed to be a patch release. |
It's not a BC, this PR just adds a |
I will backport it if it applies clean then. |
This doesn't apply clean to v4-dev, feel free to backport it manually @MartijnCuppens |
Manually backports #30781 to v4.
Inherit `font-weight: bold` that comes from user agent stylesheets.
Manually backports #30781 to v4.
th
updatesth
updates: Inherit font-weight: bold
that comes from user agent stylesheets.
Inherits
font-weight: bold
that comes from user agent stylesheets.