Remove appearance from textarea #29455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Sep 27, 2019
|
No backport? |
|
No, I added that in the latest reboot changes for v5 |
|
I contacted GH Support regarding the CI not firing up. |
|
Never received a reply from support, but this should be fixed now anyway. |
MartijnCuppens
force-pushed
the
master-mc-remove-appearance-from-textarea
branch
from
1091f04 to
5804e91
Compare
MartijnCuppens
force-pushed
the
master-mc-remove-appearance-from-textarea
branch
from
5804e91 to
335364f
Compare
|
I've rebased the PR, tests are running now. |
|
Yeah but there's another bug that the merge button is disabled even with approvals and checks passing. I sent them an email, but at this point, I doubt I'll get a reply :P |
ashfahan
added a commit
to fluid-framework/Fluid
that referenced
this pull request
Oct 9, 2019
ashfahan
added a commit
to fluid-framework/Fluid
that referenced
this pull request
Oct 13, 2019
Breaking changes: 🆙 💥 Use class `.Label` instead of label element to style controls like radio, switch, file and input floating labels for better web standards and web accessibility Removed: 🔥 Remove padding from `lyt-sidebar` to let user have control over it properly 🔥 remove custom padding from `.menu` 🔥 Remove unnecessary `.btn.is-min` theme variant style Fix: 🔨 Fix `.lyt-header.is-collapsed` not working 🔨 `.menu-items` not inheriting `font-size` 🔨 not inheriting color in `.menu` when using color utilities 🔨 Add padding in nested menu items to prevent text from going into overflow area Added: ➕ 🚀 Add NEW dropdown menu component ➕ Add `border-hide` utility to hide border using transparent color ➕ Add `border-(direction)-none` utilities to remove border from specific direction ➕ Change header and sidebar color based on `$design-theme` ➕ Add active state of `btn.is-min` Updated: 🆙 Set `text-align:start` on root to support RTL languages 🆙 🔀 Rearrange Theme colors to change there cascading priority 🆙 include all src and dist files in NPM package 🆙 Align icon in center when parent has display:flex 🆙 Flexible header height and flex wrap 🆙 Update From bootstrap reboot (twbs/bootstrap#29455) 🆙 override styles instead of increasing specificity, to make style overridable 🆙 `lyt-sidebar` are static by default, they can be made fixed using using `fixed` utility class. 🆙 Lighten .menu-item Background color 🆙 inherit `text-align` value in menu-item rather than explicit overriding 🆙 Use `display:block` on menu-items instead of flex to support `text-align` utility 🆙 Apply animation on menu items only if they were with `.menu-trigger` 🆙 Apply nested menu styles on direct child this will allow menu style to stop conflicting inside other components and universal selector `*` to be limited to direct children 🆙 Decrease nested menu animation duration 🆙 Increase before border-color transition duration in `.menu-item` to shorten and decrease chances of user specifies value more than transition duration 🆙 use scale to flip caret in menu instead of rotate Design: 💅 Don't override text `color` in `menu-item` Dev: ➕Add `fill-direction` parameter for @mixin animation 🔖
lucanos
pushed a commit
to lucanos/bootstrap
that referenced
this pull request
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was added to make
inputs andtextareas have the same border, but it seems it has a lot of unexpected side effects and support will be removed by the end of the year.Closes #29430