Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4-dev backports #29309

Merged
merged 17 commits into from
Sep 26, 2019
Merged

v4-dev backports #29309

merged 17 commits into from
Sep 26, 2019

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Aug 27, 2019 •
edited
Loading

@XhmikosR XhmikosR added the v4 label Aug 27, 2019
@XhmikosR
blog example: remove unused CSS. (#29316)
c5fdc32
@XhmikosR
theming.md: bring :root up to par with Scss. (#29323)
bbde7eb 
Also, add a warning in _root.scss so that we don't miss it again.
@XhmikosR
docs: remove swatches for theme colors. (#29327)
6010a4a 
Use the built-in utilities instead.
@XhmikosR
carousel.md: Remove duplicate bd-example div. (#29341)
85f5220 
The example shortcode already adds this.
@XhmikosR XhmikosR marked this pull request as ready for review September 2, 2019 14:23
@XhmikosR XhmikosR requested a review from a team as a code owner September 2, 2019 14:23
@XhmikosR
Copy link
Member Author

XhmikosR commented Sep 2, 2019 •
edited
Loading

@twbs/css-review I backported #29073. Please make sure everything fine because I had to make some changes due to Jekyll in this branch.

@XhmikosR
Copy link
Member Author

XhmikosR commented Sep 2, 2019 •
edited
Loading

Judging by https://deploy-preview-29309--twbs-bootstrap.netlify.com/docs/4.3/components/card/#grid-cards I think we are better using more cards per row. What do you think?

EDIT: Or maybe making the card images taller.

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 3 times, most recently from 92ae942 to 47395fa Compare September 2, 2019 14:40
@XhmikosR XhmikosR mentioned this pull request Sep 3, 2019
Merged
mdo and others added 6 commits September 4, 2019 12:30
@mdo @XhmikosR
First pass at .row-cols classes
bc92445 
Trying to find a new way to do responsive card decks while not locking ourselves into the cards themselves. My thinking here is we can easily control the column (.col) width by the parent, but I don't know how many we need (have 0-5 now) across each breakpoint. This works for cards so far, and I think could get us equal height, too.
@mdo @XhmikosR
Move margins, and equal height via utility example
f061d06
@mdo @XhmikosR
Cleanup
c25d1d9 
- Rename and move the variable to variables file
- Move code to the grid file
- Use the mixin to generate our own classes
- Wrap in a grid classes enabled conditional
- Document the mixin
@ysds @XhmikosR
Allow override default col width
27c4651
@ysds @XhmikosR
Add responsive example
bedb464
@XhmikosR
Bump bundlesize limits.
80394a2
@XhmikosR
Copy link
Member Author

@twbs/css-review Ping for review

@XhmikosR
Copy link
Member Author

Also, see my previous comment above

@ysds ysds mentioned this pull request Sep 13, 2019
Merged
@ysds
Copy link
Contributor

ysds commented Sep 13, 2019

@XhmikosR I created #29409 :)

@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from dcf2f83 to 9adcbc7 Compare September 19, 2019 13:38
@XhmikosR
workflows/test.yml: use ruby-version.
dd54ec3 
`version` is deprecated.
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from 0b76da8 to 39fd40c Compare September 24, 2019 09:51
@XhmikosR
Copy link
Member Author

@ysds can you check out the branch and review? I changed the height to 180 in this branch only, https://deploy-preview-29309--twbs-bootstrap.netlify.com/docs/4.3/components/card/#grid-cards

ysds
ysds reviewed Sep 26, 2019
View reviewed changes
scss/_root.scss Show resolved Hide resolved
@XhmikosR XhmikosR merged commit 1f2b048 into v4-dev Sep 26, 2019
@XhmikosR XhmikosR deleted the v4-dev-xmr branch September 26, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysds ysds ysds approved these changes

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XhmikosR @ysds @MartijnCuppens @mdo