-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added !important to sr-only and sr-only-focusable SASS mixins #28701
Added !important to sr-only and sr-only-focusable SASS mixins #28701
Conversation
This is regarding #28691 |
@patrickhlauke I added comment in #28691. Could you re-review the necessity need to set "! Important" for all properties? |
@ysds i really don't see the harm of just having everything |
Hmm, this looks like a nothing can go wrong here PR, but @ysds' seems to be right here. Adding I think we should have a look at which properties are still necessary and then rethink about which should be I also just noticed we did a way shorter notation for the button groups, maybe that's more what we should look into: bootstrap/scss/_button-group.scss Lines 156 to 161 in 09c99fe
|
I'm not sure I'm seeing the issue in that codepen. The sr-only button appears only when focused, which appears to be functioning correctly... EDIT: Ah I see now the button sizing or padding is not correct. |
Maybe the solution on |
Closes #28691