Fixes a bug when the [data-tabs] or [data-pills] called multiple times #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in a page causes all tabs to be associated together.
|
this is not the right way to solve this problem, as it takes delegation away and won't pick up tabs added after load. |
|
You're right, sorry about the false alarm. |
|
Found the issue: e.liveFired on line 31 is pulling "body" instead of the parent "ul". Changing line 31 from |
|
yeah, we changed it to closest https://github.com/twitter/bootstrap/blob/master/js/bootstrap-tabs.js#L31 |
DocX
pushed a commit
to DocX/bootstrap
that referenced
this pull request
Sep 16, 2014
Change the checks for Asset Pipeline from the version of Rails to the presence of Sprockets
mikejr83
pushed a commit
to SumTotalSystems/bootstrap
that referenced
this pull request
Mar 29, 2016
AMD definition fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where using the [data-tabs] or [data-pills] multiple times in a page causes all tabs to be associated together.
Sample code to trigger bug on a page w/ bootstrap being used:
`
- Link1
- Link2
`If you clicked on "Link2" in "tabgroup1" after loading the page, it will become active and all other tabs (including those in "tabgroup2" would become inactive, even though they are in a different tabgroup.