Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internet Explorer leftovers. #28349

Closed
wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Feb 23, 2019

Untested!

There are more cases in _modal.scss but I thought someone else should tackle those.

@XhmikosR XhmikosR requested a review from mdo February 23, 2019 06:55
@XhmikosR XhmikosR requested a review from a team as a code owner February 23, 2019 06:55
@XhmikosR
Copy link
Member Author

BTW maybe we should leave these? On the other hand we removed a few IE specific CSS stuff already.

The idea was if one wanted to support IE, they could add the prefixes and the polyfills. So I'm not sure which way to go. But we should be consistent.

@patrickhlauke
Copy link
Member

It would be nice if a site didn't completely break/explode in IE11. so walking the fine line of not trying to patch things to work in IE11, but have it at least present content in a semi-sensible way...

@XhmikosR
Copy link
Member Author

XhmikosR commented Feb 23, 2019

Yeah, I don't know myself either. Because if we are going the way you suggest, which is fine by me, we should actually revert a couple of changes that have landed on master.

@Herst
Copy link
Contributor

Herst commented Feb 28, 2019

But at least nobody needs to care about IE10: #25100

@XhmikosR
Copy link
Member Author

Yeah, the discussion is for IE 11.

@ray73864
Copy link

ray73864 commented Mar 7, 2019

Would love to have used Bootstrap 5 when it comes out, but the lack of IE11 support would be a deal-breaker for me unfortunately.

In our business, all our stores log onto a series of terminal servers (our admin people log onto another one), a store might have 5 thin clients and all 5 are logged onto the same user, the unfortunates of Chrome, Firefox, etc... is that they don't support session-profiles, only user-profiles, so with 5 logged into the same user, the first one to open Chrome/FF sets the lock on the profile and both require kludges to get them to be semi-useful.

We have in the past attempted Chrome, but it's never been 100% successful. IE on the other hand supports user-session profiles, so each logged in session has a slightly separate way of using the browser (especially from the task-manager POV).

If there was a stylesheet + polyfills for V5 that allow it to continue to work on IE11 that would be super-awesome, then I could get rid of jQuery completely.

@XhmikosR XhmikosR force-pushed the master-xmr-rm-ie11-leftover branch from 83ef2ff to bf39982 Compare March 14, 2019 00:52
@XhmikosR
Copy link
Member Author

Closing since we are going to keep IE 11 support for v5.

@XhmikosR XhmikosR closed this Mar 16, 2019
@XhmikosR XhmikosR deleted the master-xmr-rm-ie11-leftover branch March 16, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants