-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc update - remove media-breakpoint-up(xs) #26316
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d31f13c
Doc update - remove media-breakpoint-up(xs)
DavidDeSloovere 510be3d
Improve media-breakpoint-up/down docs
DavidDeSloovere 2242a74
Merge branch 'v4-dev' into patch-1
DavidDeSloovere 687506e
Fix indenting
DavidDeSloovere f3a48b0
Merge branch 'v4-dev' into patch-1
DavidDeSloovere 3eae0cb
correct some docs text
mdo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,7 @@ Bootstrap primarily uses the following media query ranges—or breakpoints—in | |
|
||
{% highlight scss %} | ||
// Extra small devices (portrait phones, less than 576px) | ||
// No media query since this is the default in Bootstrap | ||
// No media query for `xs` since this is the default in Bootstrap | ||
|
||
// Small devices (landscape phones, 576px and up) | ||
@media (min-width: 576px) { ... } | ||
|
@@ -70,15 +70,18 @@ Bootstrap primarily uses the following media query ranges—or breakpoints—in | |
Since we write our source CSS in Sass, all our media queries are available via Sass mixins: | ||
|
||
{% highlight scss %} | ||
@include media-breakpoint-up(xs) { ... } | ||
// No media query necessary for xs breakpoint as it's effectively `@media (min-width: 0) { ... }` | ||
@include media-breakpoint-up(sm) { ... } | ||
@include media-breakpoint-up(md) { ... } | ||
@include media-breakpoint-up(lg) { ... } | ||
@include media-breakpoint-up(xl) { ... } | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's insert an example then to back up that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added example, hope I interpreted the comment correctly. |
||
// Example usage: | ||
// Example: Hide starting at `min-width: 0`, and then show at the `sm` breakpoint | ||
.custom-class { | ||
display: none; | ||
} | ||
@include media-breakpoint-up(sm) { | ||
.some-class { | ||
.custom-class { | ||
display: block; | ||
} | ||
} | ||
|
@@ -112,6 +115,14 @@ Once again, these media queries are also available via Sass mixins: | |
@include media-breakpoint-down(sm) { ... } | ||
@include media-breakpoint-down(md) { ... } | ||
@include media-breakpoint-down(lg) { ... } | ||
// No media query necessary for xl breakpoint as it has no upper bound on its width | ||
|
||
// Example: Style from medium breakpoint and down | ||
@include media-breakpoint-down(md) { | ||
.custom-class { | ||
display: block; | ||
} | ||
} | ||
{% endhighlight %} | ||
|
||
There are also media queries and mixins for targeting a single segment of screen sizes using the minimum and maximum breakpoint widths. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's actually swap this with something that explicitly states there's no
xs
query?// No media query necessary for `xs` breakpoint as it's effectively `@media (min-width: 0) { ... }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. People might think 'where is xs'.