.input-group-text vars
#25732
Closed
.input-group-text vars
#25732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Renaming the variables is considered a breaking change. We'd need to reassign them or drop that part. |
|
Indeed that's a breaking change. We can leave in this PR the breaking change, to remain relevant for who saw it :) I can keep this PR rebased for when/if we'll need it. |
zalog
force-pushed
the
zalog-input-group-text
branch
2 times, most recently
from
b31748b to
2aee76b
Compare
|
Deleted the second commit, rebased this and made a new pr #25785 |
zalog
force-pushed
the
zalog-input-group-text
branch
from
2aee76b to
e0bedea
Compare
zalog
force-pushed
the
zalog-input-group-text
branch
from
e0bedea to
2abfa4c
Compare
|
Closing this out given it's a breaking change. Thanks for splitting the commits up earlier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit renames
$input-group-addon-*to$input-group-text-*to keep up with the new class.input-group-text.The second commit it's just a simple aligning.
Later edit: I deleted the second commit.