-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use callout without custom jekyll plugin #25320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more verbose, but I appreciate the removal of a plugin.
@mdo What do you think of write the trailing as an one-liner: {% endcapture %}{% include callout.html content=callout type="danger" %} |
@mdo: I'd like to review the build-related PRs, so please CC me. I'll test this and the other one that I haven't tested and comment when I have some time. |
Haven't had the time to test this one and #25334, but have you seen any changes in build time? I'm not sure what to expect since Ruby is just slow for some cases. |
5c470a2
to
e7c23b8
Compare
cbff46c
to
db8b1a0
Compare
@XhmikosR Can I support or help you with something to push this thought the finish line? |
@m5o: I haven't forgot about it, I just haven't got the time to review your PRs yet. Bear with me, and I'll get to it soon-ish :) |
@XhmikosR I'am very close to present a solution to get rid of the last custom plugin for building the toc. This PR is currently blocking me. I have to do minor markup change in the callout includes and don't want to do it twice. Please don't forget me :o) |
I won't. But personally, I'm against dropping the Jekyll plugin for TOC. We will never build on GH automatically so it makes no sense. What it makes sense is to try to speed things up if possible. |
84eae69
to
6ebc4cc
Compare
6ebc4cc
to
24cf2a9
Compare
24cf2a9
to
1281d06
Compare
🔗 #25319