Multi accordion support + unit test

[MartijnCuppens]

Fixes #24810.

[Johann-S]

Nice PR @MartijnCuppens I'll take time to review it asap

[XhmikosR]

LGTM from a quick look. @Johann-S please verify when you can.

[Johann-S]

Is it possible to see a CodePen with your feature @MartijnCuppens ? please
And can you update your branch 😉

[MartijnCuppens]

Her you go @Johann-S: https://codepen.io/MartijnCuppens/pen/YYxpqW?editors=1000

Shall I also include an example in the docs?

[Johann-S]

I picked up this code from our documentation and your change break the current behavior see : https://codepen.io/Johann-S/pen/PEKbdR?editors=1000

The example is here in our documentation : https://getbootstrap.com/docs/4.0/components/collapse/#accordion-example
(the second one)

An example or a quick note would be rad 👍

[MartijnCuppens]

@Johann-S , doesn't data-parent need to be set on the element with the .collapse class?

[XhmikosR]

If it's breaking the current code we should make sure we add related tests and second postpone merging this for the stable...

…

On Jan 3, 2018 15:24, "Johann-S" ***@***.***> wrote: I picked up this code from our documentation and your change break the current behavior see : https://codepen.io/Johann-S/pen/PEKbdR?editors=1000 The example is here in our documentation : https://getbootstrap.com/docs/ 4.0/components/collapse/#accordion-example (the second one) An example or a quick note would be rad 👍 — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#25161 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtWbaEPnkZMILjTG9arp89L8sFL7dks5tG3-egaJpZM4RQJPy> .

[Johann-S]

Nope my bad this example is incorrect we should remove that example which isn't relevant anymore #22251 (since we removed the use or data-children)

[MartijnCuppens]

@Johann-S, I already took care of that ;) : https://github.com/twbs/bootstrap/pull/25121/files

[Johann-S]

Nice thank you @MartijnCuppens 👍