Move uglify-js's config back to CLI. #24147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had an issue that's why I moved our uglifyjs config to a separate file 😟 |
|
What issue exactly? I don't see anything wrong here... |
|
No but when I did the move to a config file it was because we had an issue but I tried now and it's seems fine 👍 |
Johann-S
approved these changes
Sep 27, 2017
|
can you keep |
Johann-S
requested changes
Sep 27, 2017
package.json
Outdated
| "js-minify-bundle": "uglifyjs --config-file build/uglifyjs.config.json --output dist/js/bootstrap.bundle.min.js dist/js/bootstrap.bundle.js", | ||
| "js-minify-docs": "uglifyjs --config-file build/uglifyjs.config.json --output assets/js/docs.min.js assets/js/vendor/anchor.min.js assets/js/vendor/clipboard.min.js assets/js/vendor/holder.min.js assets/js/src/application.js assets/js/src/pwa.js", | ||
| "js-minify-standalone": "uglifyjs --compress --mangle --comments \"/^!/\" --output dist/js/bootstrap.min.js dist/js/bootstrap.js", | ||
| "js-minify-bundle": "uglifyjs --compress --mangle --comments \"/^!/\" --output dist/js/bootstrap.bundle.min.js dist/js/bootstrap.bundle.js", |
There was a problem hiding this comment.
should be --comprend typeofs=false --mangle --comments \"/^!/\"
related to #23770
We need to pass different options and this seems cleaner at this point. In order for docs.min.js to keeps all comments, we don't pass `compress`.
XhmikosR
force-pushed
the
v4-dev-xmr-uglify-config
branch
from
67a77b6 to
b913755
Compare
Johann-S
approved these changes
Sep 28, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to pass different options and this seems cleaner at this point.
In order for docs.min.js to keeps all comments, we don't pass
compress.This basically reverts #22990.
Fixes #24139