Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back cursor: pointer for .btn-link #24000

Closed
wants to merge 1 commit into from
Closed

Add back cursor: pointer for .btn-link #24000

wants to merge 1 commit into from

Conversation

jeffbowen
Copy link

232e86d makes total sense but buttons with class .btn-link should still display a cursor.

232e86d makes total sense but buttons with class `.btn-link` should still display a cursor.
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm split on this. I can see the rationale (it's styled to look like a link, so should have the standard pointer cursor for links), but the same argument could be made in reverse for .btn (it's styled like a button, so a link styled as button should have the default cursor for buttons). deferring to @mdo for decision.

@patrickhlauke
Copy link
Member

as an added point: i can see this whole thing confusing users either way. a button styled to look like a link, but without the cursor:pointer, will look strange to some users; a button styled as a link, and even more so when it DOES have cursor:pointer, may lead some users to think they can do things like middle-click to open in new tab, or get a link-specific context menu... (but that's a more fundamental issue with mimicking the look of a link)

@mdo mdo removed the on-hold label Oct 3, 2017
@mdo
Copy link
Member

mdo commented Dec 28, 2017

Nullified by #25082.

@mdo mdo closed this Dec 28, 2017
@jeffbowen jeffbowen deleted the jeffbowen-patch-1 branch September 20, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants