-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missed offset feature within row-fluid #2394
Conversation
…less file like this and it worked for me so please check it if it doesn't have any hidden problems.
As far as I tested it, it works for me. Proportions are correctly computed. Good job! |
In retrospect, I would modify your code slightly, although this will not be compatible for IE < 9:
This way, I can still change fluid row styles in a media query without being overridden by the !important flag. |
You'll have to use a different approach, one without |
Going to close this out. We'll add the offsets to fluid when we can get it 100% right without any nasty overrides. |
Is this the solution maybe, without nasty overrides? I try it on my own installation and it works... .row-fluid [class*="span"].offset12 {
margin-left: 102%;
}
.row-fluid [class*="span"].offset11 {
margin-left: 93.5%;
}
.row-fluid [class*="span"].offset10 {
margin-left: 85%;
}
.row-fluid [class*="span"].offset9 {
margin-left: 76.5%;
}
.row-fluid [class*="span"].offset8 {
margin-left: 68%;
}
.row-fluid [class*="span"].offset7 {
margin-left: 59.5%;
}
.row-fluid [class*="span"].offset6 {
margin-left: 51%;
}
.row-fluid [class*="span"].offset5 {
margin-left: 42.5%;
}
.row-fluid [class*="span"].offset4 {
margin-left: 34%;
}
.row-fluid [class*="span"].offset3 {
margin-left: 25.5%;
}
.row-fluid [class*="span"].offset2 {
margin-left: 17%;
}
.row-fluid [class*="span"].offset1 {
margin-left: 8.5%;
}
```css |
@jooag What purpose would And don't forget browser support. Does it work in all browsers? I assume not since the current mixins contain IE width overrides to make minor adjustments. |
It was only an first idea! I am not so familiar with github. I try to learn it. offset12 exists in the original bootstrap.css too. In this case is offset12 uneseccary. Best regards |
This fella seemed to has come up with a decent solution: |
This would be a really useful addition to bootstrap. I'm just switching a project from fixed to fluid and the lack of offset for fluid was a bit of a surprise. :) |
It appears that fluid offsetting is not yet implemented. Is that correct? If so, any chance you (@markdotto ?) can fix the docs here to remove the section that claims fluid offsetting works? (The example code there uses fixed-grid, not fluid). |
@Symmetric it's already in 2.1 release :-) |
I missed the offset feature within row-fluid. I tried to edit the mixins.less file like this and it worked for me so please check it if it doesn't have any hidden problems.