Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of the color-yiq function #23191

Closed
wants to merge 2 commits into from
Closed

Conversation

envolute
Copy link
Contributor

@envolute envolute commented Aug 1, 2017

Fixes #23114.

This change refers to the issue twbs#23114
@@ -49,17 +49,17 @@
}

// Color contrast
@mixin color-yiq($color) {
@mixin color-yiq($color, $prop: 'color') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings

@mdo
Copy link
Member

mdo commented Oct 17, 2017

Punting on this one in favor of either #23748 or #23943. Thanks though!

@mdo mdo closed this Oct 17, 2017
@mdo mdo removed the on-hold label Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants