-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: New favicons and add a service worker #23101
Conversation
Overlapping with #22895 but I prefer this way to update our favicon 👍 |
Doesn't overlap because I kept favicon.ico in root for this reason :) |
c75ff77
to
39f62cc
Compare
Added a service worker. |
What's the goal of this Service Worker ? |
https://developers.google.com/web/progressive-web-apps/ First thing I want to make https://developers.google.com/web/updates/2017/02/improved-add-to-home-screen work and then we can look into the offline stuff. |
#22895 was slated for Beta 2, not Beta 1. Similarly, this PR isn't in scope for our first beta release either. Before we attempt to merge, let's better understand what this is and why we need it. As an aside, 3% of our docs traffic is from Android. I have a hard time justifying new code and optimizations there given the audience size. Not saying that PWA are bad in general, just that we don't really gain much of anything by doing this. |
39f62cc
to
2c627b7
Compare
@mdo: this isn't only for Android, since PWAs are the future. It's just that currently that's where it works. This is a nice addition and along with offline capabilities which I plan to add, would help reading our docs offline etc. |
1a07307
to
539e66e
Compare
@@ -0,0 +1 @@ | |||
// empty for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to merge an empty file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, otherwise it's a 404. This is until we actually add any code for service workers.
d5fcbc7
to
7b99c46
Compare
Include everything for most browsers to work including Android. Kept favicon.ico to the root dir. Also added a manifest.json for PWA.
7b99c46
to
20abbc3
Compare
Include everything for most browsers to work including Android.
Kept favicon.ico to the root dir.
/CC @mdo @bardiharborow @Johann-S