Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errata from #23094. #23099

Merged
merged 1 commit into from
Jul 16, 2017
Merged

Errata from #23094. #23099

merged 1 commit into from
Jul 16, 2017

Conversation

bardiharborow
Copy link
Member

package-lock.json didn't check in properly for #23094 due to ba3c61b (now reverted).

@bardiharborow bardiharborow added this to the v4.0.0-beta milestone Jul 16, 2017
@mdo mdo mentioned this pull request Jul 16, 2017
@bardiharborow bardiharborow merged commit a83a018 into v4-dev Jul 16, 2017
@bardiharborow bardiharborow deleted the deps branch July 16, 2017 05:07
@mdo
Copy link
Member

mdo commented Jul 16, 2017

Nooooooo the package-lock.json. 😭

Mostly jk-ing. I'm just amazed that we have a 6,000 line file for our dependencies.

@bardiharborow
Copy link
Member Author

@mdo, remember that we've always had build/npm-shrinkwrap.json, this just switches to package-lock.json which is better for several reasons (happy to discuss if need be).

@mdo
Copy link
Member

mdo commented Jul 18, 2017

Hah, just playing around. Front-end development is all sorts of messed up these days 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants