Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: accessibility and IE fixes for SVG-based top navigation #22848

Merged
merged 4 commits into from
Jun 17, 2017
Merged

Docs: accessibility and IE fixes for SVG-based top navigation #22848

merged 4 commits into from
Jun 17, 2017

Conversation

patrickhlauke
Copy link
Member

  • fixes issue of some browser/AT combinations not reading an <svg>'s <title> for the link text (by adding an explicit aria-label to the link)
  • fixes issue of IE explicitly focusing on <svg> elements (resulting in two tab stops for each <svg>-based link - one for the link, one for the nested <svg>)

As some browser/AT combinations don't seem to fully support grabbing the
`<title>` from inside the `<svg>` as the link text/name to announce
(e.g. Firefox+NVDA)
Due to a bug/"feature" in IE, `<svg>` elements are usually separately
focusable, which then results in links with `<svg>` icons being
essentially focused twice (once for the link, and once for the `<svg>`
inside, which is then also non-interactive)
@patrickhlauke
Copy link
Member Author

hmmm, travis is taking an inordinately long time to run here it seems...

@mdo mdo mentioned this pull request Jun 17, 2017
@patrickhlauke patrickhlauke merged commit 816d5bd into twbs:v4-dev Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant