Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - avoid Tooltips/Popovers overflow on documentations's navbar #22733

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Jun 1, 2017

This PR avoid this effect on our new awesome documentation

popovers bootstrap - mozilla firefox

By the way, thank you @mdo for your awesome work on our new documentation ❤️

/CC @mdo

@Johann-S Johann-S added this to the v4.0.0-beta milestone Jun 1, 2017
@mdo
Copy link
Member

mdo commented Jun 1, 2017

Is this a problem for all popovers and tooltips, for all navbars? Do we need to revisit the z-index of a sticky navbar, or is my docs navbar (which uses a custom sticky style) missing the z-index?

@Johann-S
Copy link
Member Author

Johann-S commented Jun 1, 2017

This problem is just fort Tooltip/Popover examples in our documentation.
I should change my fix to target only examples Tooltip/Popovers.
It's due to a low z-index of the sticky navbar in our documentation

@mdo
Copy link
Member

mdo commented Jun 1, 2017

I should change my fix to target only examples Tooltip/Popovers.
It's due to a low z-index of the sticky navbar in our documentation

Yup, sounds right to me! ;)

@Johann-S Johann-S force-pushed the v4-docs-tooltips-overflow branch from 263d94c to 730a049 Compare June 1, 2017 20:15
@Johann-S
Copy link
Member Author

Johann-S commented Jun 1, 2017

finally the best solution was to change navbar's z-index because dynamic Tooltips/Popovers example are added to the end of the <body>
I chose 1071 because 1070 it's the Tooltips z-index

@Johann-S Johann-S force-pushed the v4-docs-tooltips-overflow branch from 7616906 to 6822fd8 Compare June 7, 2017 17:28
@Johann-S Johann-S merged commit 1a0a1a0 into v4-dev Jun 7, 2017
@Johann-S Johann-S deleted the v4-docs-tooltips-overflow branch June 7, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants