Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak iOS hack for dropdown #22482

Merged
merged 2 commits into from
Apr 20, 2017
Merged

Tweak iOS hack for dropdown #22482

merged 2 commits into from
Apr 20, 2017

Conversation

patrickhlauke
Copy link
Member

Tweak to #22426, where the wrong selector slipped through the net (selecting all of <body>s grand-children rather than children)

@patrickhlauke
Copy link
Member Author

/cc @Johann-S

@patrickhlauke patrickhlauke merged commit 1f37c53 into twbs:v4-dev Apr 20, 2017
@mdo mdo mentioned this pull request Apr 20, 2017
@@ -111,7 +111,7 @@ const Dropdown = (($) => {
// https://www.quirksmode.org/blog/archives/2014/02/mouse_event_bub.html
if ('ontouchstart' in document.documentElement &&
!$(parent).closest(Selector.NAVBAR_NAV).length) {
$('body').children().on('mouseover', '*', $.noop)
$('body').children().on('mouseover', null, $.noop)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just omit the 2nd argument in this case. Right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but i thought i'd make it explicit (since that's what tripped up an earlier review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants