Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More minor build tweaks. #22477

Merged
merged 1 commit into from
Apr 21, 2017
Merged

More minor build tweaks. #22477

merged 1 commit into from
Apr 21, 2017

Conversation

bardiharborow
Copy link
Member

@bardiharborow bardiharborow commented Apr 20, 2017

Closes #22388. Closes #22476. Closes #22490.

@Johann-S
Copy link
Member

Is it possible @bardiharborow to clear a bit because in logs they are all the requests logged and it's useless for us for example : https://travis-ci.org/twbs/bootstrap/jobs/223901460#L1161

@bardiharborow
Copy link
Member Author

@Johann-S
Copy link
Member

Nice thank you @bardiharborow 👍

@Johann-S Johann-S mentioned this pull request Apr 20, 2017
41 tasks
@patrickhlauke
Copy link
Member

new build system seems borked on windows at the moment? did a completely fresh node installation, tried npm install, and it errors out

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

@wolfy1339
Copy link
Contributor

@patrickhlauke that's normal on Windows, it hapens all the time.
fsevents is only for macOS/OSX

@patrickhlauke
Copy link
Member

@wolfy1339 didn't happen in previous build system. ok, as it's marked as optional, ignoring.

running npm run test it then fails (despite latest node) here

'export).*' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 255
npm ERR! [email protected] js-compile-bundle: `shx cat js/src/util.js js/src/alert.js js/src/button.js js/src/carousel.js js/src/collapse.js js/src/dropdown.js js/src/modal.js js/src/scrollspy.js js/src/tab.js js/src/tooltip.js js/src/popover.js | shx sed 's/^(import|export).*//' | babel --filename js/src/bootstrap.js | node build/stamp.js > dist/js/bootstrap.js`

(sorry, not trying to be difficult...just hoping these can be resolved and these cryptic messages mean something to you folks, as i'm hopelessly lost in this command line stuff and just want to get back to a working build environment to tackle some issues :) )

@Johann-S
Copy link
Member

@patrickhlauke fixed in this PR, also reported by me

@patrickhlauke
Copy link
Member

@Johann-S ah ok cool. it's all greek to me, so not even tried checking this PR out. i'll hang fire in hopes that it gets merged soon...

@Johann-S
Copy link
Member

@bardiharborow How can I use watch task in our new build system ? Because it's an convenient task and I'm afraid this task is missing 😨

@bardiharborow
Copy link
Member Author

@patrickhlauke hey, sorry for breaking Windows support, that was not very well tested from my end. I'm merging this now. Please ping me if there's anything else broken. I might try to get hold of a Windows box to test as well.

@bardiharborow bardiharborow merged commit 2906b61 into twbs:v4-dev Apr 21, 2017
@bardiharborow bardiharborow deleted the build-tweaks branch April 21, 2017 11:08
@mdo mdo mentioned this pull request Apr 21, 2017
@patrickhlauke
Copy link
Member

patrickhlauke commented Apr 21, 2017

@bardiharborow sorry, was being more cranky then usual there. will give this a whirl and report back in a happier mood :)

(wrangling with the command line does that to me...)

@patrickhlauke
Copy link
Member

just tested. npm run test runs smooth now, but fails at linting stage

[htmllint] found 256 errors out of 102 files

are the linting rules new/changed in this new build process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants