-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 - Remove Tether for Popper #22444
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
de0f48d
Use Popper for tooltip and popover
Johann-S 7492478
Begin to add arrow to Popover and Tooltip
Johann-S e4f7a07
Add attachment classes
Johann-S 2a10fbe
Fix arrow for tooltip and popover
Johann-S 4492457
Begin to use Popper for Dropdown
Johann-S 6d39a0e
Remove constraints option and check every options
Johann-S 7dd6936
Fix unit tests + Update Popper to 1.6.0
Johann-S 5dfd78b
Handle dropup for Dropdown
Johann-S a2dae3c
Remove Tether from package.json + Update Popper
Johann-S feb99a9
Remove totaly Tether from documentation + dependencies
Johann-S 84186b4
Better placement for Dropdown + Handle flip of Tooltip/Popover
Johann-S c4b33e1
Fix some css for the arrow of Popover/Tooltip + update documentation
Johann-S 7478383
Add an update method to allow to update position for Tooltip/Popover/…
Johann-S 8ac71e8
Update Popper.js 1.8.2
Johann-S cc14d85
Update shrinkwrap.
bardiharborow 766f854
Allow to disable flip behaviour on Dropdown + documentation
Johann-S cbc5a4e
Documentation - fix examples for Tooltip and Popovers (display arrow)
Johann-S f5bc25a
Fix dropdown-menu-right and dropdown-menu-left for Dropdown
Johann-S 70283d6
Update Popper.js 1.9.1 + Update documentation about Dropdown placement
Johann-S 1f5e127
Fix dropdown in scrollspy visual test (add Popper.js)
Johann-S 17a166c
Add fallbackPlacement option for Tooltip and Popover
Johann-S e8da1bb
Use _jQueryInterface for Dropdown to call toggle method
Johann-S ff5432f
Fix bad position for Tooltips with animation at true
Johann-S b37c426
Fix tooltip margin to be stick at their caller
Johann-S d65a565
Change fallbackPlacement to flip by default for Tooltips/Popovers
Johann-S 083f9ca
Update Popper.js 1.9.3
Johann-S File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,6 @@ | |
], | ||
"dependencies": { | ||
"jquery": ">=1.9.1", | ||
"tether": "^1.4.0" | ||
"popper.js": "^1.9.3" | ||
} | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to rename
tooltip-top
tobs-tooltip-top
if I've understand other changesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch @Lausselloic feel free to open a PR 👍