-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing <main> element to documentation #22364
Changes from 14 commits
6b35cc0
6077120
626a756
ec75282
dd6ed1d
59e7ddd
8254a53
03d7ad4
aa13b3c
34873e9
bb21b0e
f304347
55a9816
3c2554e
2cd31ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,10 +24,10 @@ | |
<div class="col-12 col-md-3 push-md-9 bd-sidebar"> | ||
{% include nav-docs.html %} | ||
</div> | ||
<div class="col-12 col-md-9 pull-md-3 bd-content"> | ||
<main class="col-12 col-md-9 pull-md-3 bd-content" role="main"> | ||
<h1 class="bd-title" id="content">{{ page.title }}</h1> | ||
{{ content }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wondering if this may not be the more appropriate location for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Lausselloic you ok to make those change to this PR? need a hand? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry haven't seen your comment. Yes I will do it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. great stuff. will double-check it all works and merge. thanks :) |
||
</div> | ||
</main> | ||
</div> | ||
</div> | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
role="main" is not required here since we are using the
<main>
elementThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always double the main element with the aria role for IE11 who doesn't take care about this element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, it's unnecessary normally, but notoriously IE11 needs this extra
role
to make it work (as in, expose it correctly to AT). as it doesn't do any harm, this PR looks fine to me as isThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about that but it seems
main
tag isn't supported by IE10 (https://caniuse.com/#feat=html5semantic).What's the lower release of IE we support in our documentation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes main tag doesn't fit well on IE10, need to add a css
Bootstrap compatibility is IE1à and upper ( https://v4-alpha.getbootstrap.com/getting-started/browsers-devices/#desktop-browsers)
So maybe need to add a fix in the core _reboot.scss for all HTML5 semantic default display?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, in v3 we had
html5shiv
take care of that, forgot we don't have that in v4 anymore.i think it'd make sense to add the default block styling to reboot. i'll take care of that before merging this, assuming @mdo is ok with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done #22573