fix tooltips margins #22301
Closed
fix tooltips margins #22301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/CC @mdo |
IdanCo
force-pushed
the
bugfix/22300-tooltips-margins
branch
3 times, most recently
from
aadece8 to
e0af27a
Compare
|
updated jsbin - http://jsbin.com/noyitof/edit?html,css,js,output |
IdanCo
force-pushed
the
bugfix/22300-tooltips-margins
branch
from
e0af27a to
6d6bf9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As described in #21146 and #22300, and shown here, left and top tooltips exhibit inconsistencies in regards to margins.
before
Top and left tooltips sometimes ignore margins
After
All tooltips now use padding instead of margin
Technical
As shown here, top and left tooltips switches between absolute and fixed positions. No doubt this is what causes the inconsistencies, but I admit the logic behind this switch, and the reason it differs from bottom or right tooltips remains an enigma to me. It happens here, but since it's deep inside tether's logic, I tried looking for a workaround in bootstrap's code. Since the margins seems to be what causes the issue, i've successfully replaced them with paddings, while preserving the spacing by adding it to the arrow position.
Example of fix available here -
http://jsbin.com/noyitof/edit?html,css,js,output