-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) #21807
Merged
Merged
Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) #21807
Changes from 10 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
3bff97c
Fix active nav-link for nav markup
pvdlg 9fe3960
Fix nav-justified for nav markup
pvdlg 5b471f2
Fix nav-fill for nav markup
pvdlg df3dfc2
Add flex-fill utility that is referenced in the doc but not implemented
pvdlg 536aefe
Add font-size utility used in the scroll spy docs
pvdlg 1aee9d1
Detect parent to activate for both ul and nav markup, independently o…
pvdlg 16e7a05
Remove unused variables
pvdlg 98bbe1d
Unit test for both <ul> and <nav> markup
pvdlg 009da31
Update nav docs to demonstrate nav-justified + <nav> markup
pvdlg 2555b9e
Clarify dependency to nav, mentioned both <ul> and <nav> markup and a…
pvdlg 29e71b7
Display dropdown as active when dropdown shown
pvdlg 0c24034
Make tabs works with both <nav> and <ul> markup
pvdlg 6fdfbd5
Find active tab / tab-pane independently of markup
pvdlg 463caee
Fix tab-pane transitioning detection
pvdlg d69bb07
Remove unnecessary variables
pvdlg 0515419
Add example with <nav> markup and JS
pvdlg 47c439a
Fix html markup in docs
pvdlg 753a6f5
Fix more markup
pvdlg 3664142
Detect tabs list based on class .nav rather than elements
pvdlg 7a7ae03
Merge branch 'twbs/v4-dev' into nav-scrollspy
pvdlg c5cebd2
Fix aria-control
pvdlg 2392e9b
Rename NAV selector
pvdlg 4afc8c0
Add tab pills and vertical tab pills examples
pvdlg 15f7c44
Avoid double negative margin for <ul> markup
pvdlg ed386b8
Update unit test to reflect to replace tabs (that doesn't exist anymo…
pvdlg d7ebf9b
Fix htmlhint errors
pvdlg 26e2361
Improve html examples
pvdlg 689b922
Add scrollspy support to list-group
pvdlg 3bdd1b0
Add tabs support to list-group
pvdlg d90ebde
Fix typo
pvdlg 0384baa
Merge branch 'twbs/v4-dev' into nav-scrollspy
pvdlg b6c9ba6
Merge branch 'v4-dev' into nav-scrollspy
pvdlg 9843459
Merge branch 'v4-dev' into nav-scrollspy
pvdlg 569bd6c
Move nav-pills active classes under nav-pills
pvdlg 2ac5591
Drop font-size utils
pvdlg f6bafb0
Remove flex-fill utils
pvdlg b5faf2b
Drop nav-link style for nav-justified and nav-fill
pvdlg f3e2886
Merge branch 'v4-dev' into nav-scrollspy
pvdlg e8b5f79
Merge branch 'v4-dev' into nav-scrollspy
pvdlg 2ade5e7
Reverse 1a46d8c
pvdlg 3227b7b
Update visual test for scroll spy and tab
pvdlg 1996643
Fix copy/paste error in highlighted html (the actual code didn't change)
pvdlg eb7d9e0
Merge branch 'v4-dev' into nav-scrollspy
pvdlg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot see this example working because they aren't scroll and when I scroll the main scroll no
active
class addedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me on Safari, Chrome and Firefox.
The scroll is set by the class
.scrollspy-example-2
I added todocs/assets/scss/_component-examples.scss
. I guess you have to recompile the docs withgrunt docs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I thought about it after my comment my bad 👍