Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs/Scrollspy/.nav/.list-group/.active independent of markup (<nav>, .nav-item, <li> etc...) #21807

Merged
merged 43 commits into from
Apr 2, 2017
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
3bff97c
Fix active nav-link for nav markup
pvdlg Jan 21, 2017
9fe3960
Fix nav-justified for nav markup
pvdlg Jan 21, 2017
5b471f2
Fix nav-fill for nav markup
pvdlg Jan 21, 2017
df3dfc2
Add flex-fill utility that is referenced in the doc but not implemented
pvdlg Jan 21, 2017
536aefe
Add font-size utility used in the scroll spy docs
pvdlg Jan 21, 2017
1aee9d1
Detect parent to activate for both ul and nav markup, independently o…
pvdlg Jan 21, 2017
16e7a05
Remove unused variables
pvdlg Jan 21, 2017
98bbe1d
Unit test for both <ul> and <nav> markup
pvdlg Jan 21, 2017
009da31
Update nav docs to demonstrate nav-justified + <nav> markup
pvdlg Jan 21, 2017
2555b9e
Clarify dependency to nav, mentioned both <ul> and <nav> markup and a…
pvdlg Jan 21, 2017
29e71b7
Display dropdown as active when dropdown shown
pvdlg Jan 22, 2017
0c24034
Make tabs works with both <nav> and <ul> markup
pvdlg Jan 22, 2017
6fdfbd5
Find active tab / tab-pane independently of markup
pvdlg Jan 22, 2017
463caee
Fix tab-pane transitioning detection
pvdlg Jan 22, 2017
d69bb07
Remove unnecessary variables
pvdlg Jan 22, 2017
0515419
Add example with <nav> markup and JS
pvdlg Jan 22, 2017
47c439a
Fix html markup in docs
pvdlg Jan 22, 2017
753a6f5
Fix more markup
pvdlg Jan 22, 2017
3664142
Detect tabs list based on class .nav rather than elements
pvdlg Jan 22, 2017
7a7ae03
Merge branch 'twbs/v4-dev' into nav-scrollspy
pvdlg Jan 22, 2017
c5cebd2
Fix aria-control
pvdlg Jan 22, 2017
2392e9b
Rename NAV selector
pvdlg Jan 23, 2017
4afc8c0
Add tab pills and vertical tab pills examples
pvdlg Jan 23, 2017
15f7c44
Avoid double negative margin for <ul> markup
pvdlg Jan 23, 2017
ed386b8
Update unit test to reflect to replace tabs (that doesn't exist anymo…
pvdlg Jan 23, 2017
d7ebf9b
Fix htmlhint errors
pvdlg Jan 23, 2017
26e2361
Improve html examples
pvdlg Jan 23, 2017
689b922
Add scrollspy support to list-group
pvdlg Jan 24, 2017
3bdd1b0
Add tabs support to list-group
pvdlg Jan 24, 2017
d90ebde
Fix typo
pvdlg Jan 24, 2017
0384baa
Merge branch 'twbs/v4-dev' into nav-scrollspy
pvdlg Jan 24, 2017
b6c9ba6
Merge branch 'v4-dev' into nav-scrollspy
pvdlg Jan 25, 2017
9843459
Merge branch 'v4-dev' into nav-scrollspy
pvdlg Mar 19, 2017
569bd6c
Move nav-pills active classes under nav-pills
pvdlg Mar 19, 2017
2ac5591
Drop font-size utils
pvdlg Mar 20, 2017
f6bafb0
Remove flex-fill utils
pvdlg Mar 20, 2017
b5faf2b
Drop nav-link style for nav-justified and nav-fill
pvdlg Mar 20, 2017
f3e2886
Merge branch 'v4-dev' into nav-scrollspy
pvdlg Mar 28, 2017
e8b5f79
Merge branch 'v4-dev' into nav-scrollspy
pvdlg Mar 29, 2017
2ade5e7
Reverse 1a46d8c
pvdlg Mar 30, 2017
3227b7b
Update visual test for scroll spy and tab
pvdlg Mar 30, 2017
1996643
Fix copy/paste error in highlighted html (the actual code didn't change)
pvdlg Mar 30, 2017
eb7d9e0
Merge branch 'v4-dev' into nav-scrollspy
pvdlg Mar 31, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/assets/scss/_component-examples.scss
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,13 @@
overflow: auto;
}

.scrollspy-example-2 {
position: relative;
height: 450px;
margin-top: .5rem;
overflow: auto;
}

// Helpers
.bd-example > {
.bg-primary,
Expand Down
20 changes: 6 additions & 14 deletions docs/components/navs.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,20 +188,12 @@ Force your `.nav`'s contents to extend the full available width one of two modif
For equal-width elements, use `.nav-justified`. All horizontal space will be occupied by nav links, but unlike the `.nav-fill` above, every nav item will be the same width.

{% example html %}
<ul class="nav nav-pills nav-justified">
<li class="nav-item">
<a class="nav-link active" href="#">Active</a>
</li>
<li class="nav-item">
<a class="nav-link" href="#">Longer nav link</a>
</li>
<li class="nav-item">
<a class="nav-link" href="#">Link</a>
</li>
<li class="nav-item">
<a class="nav-link disabled" href="#">Disabled</a>
</li>
</ul>
<nav class="nav nav-pills nav-justified">
<a class="nav-link active" href="#">Active</a>
<a class="nav-link" href="#">Longer nav link</a>
<a class="nav-link" href="#">Link</a>
<a class="nav-link disabled" href="#">Disabled</a>
</nav>
{% endexample %}

## Working with flex utilities
Expand Down
163 changes: 155 additions & 8 deletions docs/components/scrollspy.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,53 @@ description: Documentation and examples for the scrollspy plugin with Bootstrap'
group: components
---

Automatically update nav targets based on scroll position.

## Contents

* Will be replaced with the ToC, excluding the "Contents" header
{:toc}

{% callout warning %}
#### Requires Bootstrap nav

Scrollspy requires the use of a [Bootstrap nav component]({{ site.baseurl }}/components/navs#base-nav) for proper highlighting of active links. It supports both the `<nav>` and `<ul>` markup and in both cases the element that receives the `.active` class is the `.nav-link`.
{% highlight html %}
<ul class="nav">
<li class="nav-item">
<a class="nav-link active" href="#target-id">Item</a>
</li>
</ul>
{% endhighlight %}

{% highlight html %}
<nav class="nav">
<a class="nav-link active" href="#target-id">Item</a>
</nav>
{% endhighlight %}

{% endcallout %}

{% callout warning %}
#### Requires relative positioning

No matter the implementation method, scrollspy requires the use of `position: relative;` on the element you're spying on. In most cases this is the `<body>`. When scrollspying on elements other than the `<body>`, be sure to have a `height` set and `overflow-y: scroll;` applied.
{% endcallout %}

## Example in navbar

The ScrollSpy plugin is for automatically updating nav targets based on scroll position. Scroll the area below the navbar and watch the active class change. The dropdown sub items will be highlighted as well.
Scroll the area below the navbar and watch the active class change. The dropdown sub items will be highlighted as well.

<div class="bd-example">
<nav id="navbar-example2" class="navbar navbar-light bg-faded">
<a class="navbar-brand" href="#">Navbar</a>
<ul class="nav nav-pills">
<li class="nav-item"><a class="nav-link" href="#fat">@fat</a></li>
<li class="nav-item"><a class="nav-link" href="#mdo">@mdo</a></li>
<li class="nav-item">
<a class="nav-link" href="#fat">@fat</a>
</li>
<li class="nav-item">
<a class="nav-link" href="#mdo">@mdo</a>
</li>
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Dropdown</a>
<div class="dropdown-menu">
Expand Down Expand Up @@ -47,16 +79,131 @@ The ScrollSpy plugin is for automatically updating nav targets based on scroll p
</div>
</div>

{% highlight html %}
<nav id="navbar-example2" class="navbar navbar-light bg-faded">
<a class="navbar-brand" href="#">Navbar</a>
<ul class="nav nav-pills">
<li class="nav-item">
<a class="nav-link" href="#fat">@fat</a>
</li>
<li class="nav-item">
<a class="nav-link" href="#mdo">@mdo</a>
</li>
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">Dropdown</a>
<div class="dropdown-menu">
<a class="dropdown-item" href="#one">one</a>
<a class="dropdown-item" href="#two">two</a>
<div role="separator" class="dropdown-divider"></div>
<a class="dropdown-item" href="#three">three</a>
</div>
</li>
</ul>
</nav>
<div data-spy="scroll" data-target="#navbar-example2" data-offset="0">
<h4 id="fat">@fat</h4>
<p>...</p>
<h4 id="mdo">@mdo</h4>
<p>...</p>
<h4 id="one">one</h4>
<p>...</p>
<h4 id="two">two</h4>
<p>...</p>
<h4 id="three">three</h4>
<p>...</p>
</div>
{% endhighlight %}

## Usage
## Example with sub-nav

### Requires Bootstrap nav
The ScrollSpy plugin also works with nested `.nav`s. If a sub-`.nav` is `.active`, it's parents will also be `.active`. Scroll the area below the navbar and watch the active class change.

Scrollspy currently requires the use of a [Bootstrap nav component]({{ site.baseurl }}/components/navs/) for proper highlighting of active links.
<div class="bd-example">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see this example working because they aren't scroll and when I scroll the main scroll no active class added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Safari, Chrome and Firefox.
The scroll is set by the class .scrollspy-example-2 I added to docs/assets/scss/_component-examples.scss. I guess you have to recompile the docs with grunt docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I thought about it after my comment my bad 👍

<div class="row">
<nav id="navbar-example3" class="navbar navbar-light bg-faded col-4">
<a class="navbar-brand" href="#">Navbar</a>
<nav class="nav nav-pills flex-column">
<a class="nav-link" href="#item-1">Item 1</a>
<nav class="nav nav-pills flex-column">
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-1-1">Item 1-1</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-1-2">Item 1-2</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-1-3">Item 1-3</a>
</nav>
<a class="nav-link" href="#item-2">Item2</a>
<a class="nav-link" href="#item-3">Item3</a>
<nav class="nav nav-pills flex-column">
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-3-1">Item 3-1</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-3-2">Item 3-2</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-3-3">Item 3-3</a>
</nav>
</nav>
</nav>
<div data-spy="scroll" data-target="#navbar-example3" data-offset="0" class="scrollspy-example-2 col-8">
<h4 id="item-1">Item 1</h4>
<p>Ex consequat commodo adipisicing exercitation aute excepteur occaecat ullamco duis aliqua id magna ullamco eu. Do aute ipsum ipsum ullamco cillum consectetur ut et aute consectetur labore. Fugiat laborum incididunt tempor eu consequat enim dolore proident. Qui laborum do non excepteur nulla magna eiusmod consectetur in. Aliqua et aliqua officia quis et incididunt voluptate non anim reprehenderit adipisicing dolore ut consequat deserunt mollit dolore. Aliquip nulla enim veniam non fugiat id cupidatat nulla elit cupidatat commodo velit ut eiusmod cupidatat elit dolore.</p>
<h5 id="item-1-1">Item 1-1</h5>
<p>Amet tempor mollit aliquip pariatur excepteur commodo do ea cillum commodo Lorem et occaecat elit qui et. Aliquip labore ex ex esse voluptate occaecat Lorem ullamco deserunt. Aliqua cillum excepteur irure consequat id quis ea. Sit proident ullamco aute magna pariatur nostrud labore. Reprehenderit aliqua commodo eiusmod aliquip est do duis amet proident magna consectetur consequat eu commodo fugiat non quis. Enim aliquip exercitation ullamco adipisicing voluptate excepteur minim exercitation minim minim commodo adipisicing exercitation officia nisi adipisicing. Anim id duis qui consequat labore adipisicing sint dolor elit cillum anim et fugiat.</p>
<h5 id="item-1-2">Item 2-2</h5>
<p>Cillum nisi deserunt magna eiusmod qui eiusmod velit voluptate pariatur laborum sunt enim. Irure laboris mollit consequat incididunt sint et culpa culpa incididunt adipisicing magna magna occaecat. Nulla ipsum cillum eiusmod sint elit excepteur ea labore enim consectetur in labore anim. Proident ullamco ipsum esse elit ut Lorem eiusmod dolor et eiusmod. Anim occaecat nulla in non consequat eiusmod velit incididunt.</p>
<h5 id="item-1-3">Item 2-3</h5>
<p>Ex fugiat dolore commodo et non proident incididunt elit reprehenderit. Eu excepteur aliquip id consectetur irure ut adipisicing veniam consequat non qui esse sint cupidatat do incididunt. Velit eu dolor excepteur qui exercitation aliqua nisi quis dolore exercitation proident officia culpa nostrud. Ullamco et pariatur in eu ad ut incididunt esse in ipsum excepteur ullamco duis.</p>
<h4 id="item-2">Item 2</h4>
<p>Quis magna Lorem anim amet ipsum do mollit sit cillum voluptate ex nulla tempor. Laborum consequat non elit enim exercitation cillum aliqua consequat id aliqua. Esse ex consectetur mollit voluptate est in duis laboris ad sit ipsum anim Lorem. Incididunt veniam velit elit elit veniam Lorem aliqua quis ullamco deserunt sit enim elit aliqua esse irure. Laborum nisi sit est tempor laborum mollit labore officia laborum excepteur commodo non commodo dolor excepteur commodo. Ipsum fugiat ex est consectetur ipsum commodo tempor sunt in proident.</p>
<h4 id="item-3">Item 2</h4>
<p>Quis anim sit do amet fugiat dolor velit sit ea ea do reprehenderit culpa duis. Nostrud aliqua ipsum fugiat minim proident occaecat excepteur aliquip culpa aute tempor reprehenderit. Deserunt tempor mollit elit ex pariatur dolore velit fugiat mollit culpa irure ullamco est ex ullamco excepteur.</p>
<h4 id="item-3-1">Item 3-1</h4>
<p>Irure veniam ut tempor cupidatat voluptate cupidatat do labore consequat ex sunt Lorem labore quis fugiat adipisicing. Aliqua voluptate amet ad sunt culpa cupidatat dolor. Sunt sunt aute labore nisi ex ex laboris ea duis non occaecat. Sunt proident irure veniam nostrud adipisicing est est veniam mollit non aliqua nisi deserunt nostrud culpa ullamco.</p>
<h4 id="item-3-2">Item 3-2</h4>
<p>Non eu officia consequat commodo incididunt ullamco fugiat anim ad dolor. Amet sint irure elit cillum cillum ex ad aute tempor ut aliquip reprehenderit ut. Consectetur minim est labore Lorem occaecat minim fugiat ex excepteur consequat nisi pariatur.</p>
<h4 id="item-3-3">Item 3-3</h4>
<p>Labore sit culpa commodo elit adipisicing sit aliquip elit proident voluptate minim mollit nostrud aute reprehenderit do. Mollit excepteur eu Lorem ipsum anim commodo sint labore Lorem in exercitation velit incididunt. Occaecat consectetur nisi in occaecat proident minim enim sunt reprehenderit exercitation cupidatat et do officia. Aliquip consequat ad labore labore mollit ut amet. Sit pariatur tempor proident in veniam culpa aliqua excepteur elit magna fugiat eiusmod amet officia.</p>
<p>Deserunt quis elit Lorem eiusmod amet enim enim amet minim Lorem proident nostrud. Ea id dolore anim exercitation aute fugiat labore voluptate cillum do laboris labore. Ex velit exercitation nisi enim labore reprehenderit labore nostrud ut ut. Esse officia sunt duis aliquip ullamco tempor eiusmod deserunt irure nostrud irure. Ullamco proident veniam laboris ea consectetur magna sunt ex exercitation aliquip minim enim culpa occaecat exercitation. Est tempor excepteur aliquip laborum consequat do deserunt laborum esse eiusmod irure proident ipsum esse qui.</p>
</div>
</div>
</div>

### Requires relative positioning
{% highlight html %}
<nav id="navbar-example3" class="navbar navbar-light bg-faded">
<a class="navbar-brand" href="#">Navbar</a>
<nav class="nav nav-pills flex-column">
<a class="nav-link" href="#item-1">Item 1</a>
<nav class="nav nav-pills flex-column">
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-1-1">Item 1-1</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-1-2">Item 1-2</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-1-3">Item 1-3</a>
</nav>
<a class="nav-link" href="#item-2">Item2</a>
<a class="nav-link" href="#item-3">Item3</a>
<nav class="nav nav-pills flex-column">
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-3-1">Item 3-1</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-3-2">Item 3-2</a>
<a class="nav-link ml-3 my-1 font-size-sm" href="#item-3-3">Item 3-3</a>
</nav>
</nav>
</nav>
<div data-spy="scroll" data-target="#navbar-example3" data-offset="0">
<h4 id="item-1">Item 1</h4>
<p>...</p>
<h5 id="item-1-1">Item 1-1</h5>
<p>...</p>
<h5 id="item-1-2">Item 2-2</h5>
<p>...</p>
<h5 id="item-1-3">Item 2-3</h5>
<p>...</p>
<h4 id="item-2">Item 2</h4>
<p>...</p>
<h4 id="item-3">Item 2</h4>
<p>...</p>
<h4 id="item-3-1">Item 3-1</h4>
<p>...</p>
<h4 id="item-3-2">Item 3-2</h4>
<p>...</p>
<h4 id="item-3-3">Item 3-3</h4>
<p>...</p>
</div>
{% endhighlight %}

No matter the implementation method, scrollspy requires the use of `position: relative;` on the element you're spying on. In most cases this is the `<body>`. When scrollspying on elements other than the `<body>`, be sure to have a `height` set and `overflow-y: scroll;` applied.
## Usage

### Via data attributes

Expand Down
12 changes: 5 additions & 7 deletions js/src/scrollspy.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,13 @@ const ScrollSpy = (($) => {
const ClassName = {
DROPDOWN_ITEM : 'dropdown-item',
DROPDOWN_MENU : 'dropdown-menu',
NAV_LINK : 'nav-link',
NAV : 'nav',
ACTIVE : 'active'
}

const Selector = {
DATA_SPY : '[data-spy="scroll"]',
ACTIVE : '.active',
LIST_ITEM : '.list-item',
LI : 'li',
LI_DROPDOWN : 'li.dropdown',
NAV_LINKS : '.nav-link',
DROPDOWN : '.dropdown',
DROPDOWN_ITEMS : '.dropdown-item',
Expand Down Expand Up @@ -256,9 +252,11 @@ const ScrollSpy = (($) => {
$link.closest(Selector.DROPDOWN).find(Selector.DROPDOWN_TOGGLE).addClass(ClassName.ACTIVE)
$link.addClass(ClassName.ACTIVE)
} else {
// todo (fat) this is kinda sus...
// recursively add actives to tested nav-links
$link.parents(Selector.LI).find(`> ${Selector.NAV_LINKS}`).addClass(ClassName.ACTIVE)
// Set triggered link as active
$link.addClass(ClassName.ACTIVE)
// Set triggered links parents as active
// With both <ul> and <nav> markup a parent is the previous sibling of any nav ancestor
$link.parents().prev(Selector.NAV_LINKS).addClass(ClassName.ACTIVE)
}

$(this._scrollElement).trigger(Event.ACTIVATE, {
Expand Down
77 changes: 77 additions & 0 deletions js/tests/unit/scrollspy.js
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,43 @@ $(function () {
.then(function () { done() })
})

QUnit.test('should add the active class to the correct element (nav markup)', function (assert) {
assert.expect(2)
var navbarHtml =
'<nav class="navbar">'
+ '<nav class="nav">'
+ '<a class="nav-link" id="a-1" href="#div-1">div 1</a>'
+ '<a class="nav-link" id="a-2" href="#div-2">div 2</a>'
+ '</nav>'
+ '</nav>'
var contentHtml =
'<div class="content" style="overflow: auto; height: 50px">'
+ '<div id="div-1" style="height: 100px; padding: 0; margin: 0">div 1</div>'
+ '<div id="div-2" style="height: 200px; padding: 0; margin: 0">div 2</div>'
+ '</div>'

$(navbarHtml).appendTo('#qunit-fixture')
var $content = $(contentHtml)
.appendTo('#qunit-fixture')
.bootstrapScrollspy({ offset: 0, target: '.navbar' })

var done = assert.async()
var testElementIsActiveAfterScroll = function (element, target) {
var deferred = $.Deferred()
var scrollHeight = Math.ceil($content.scrollTop() + $(target).position().top)
$content.one('scroll', function () {
assert.ok($(element).hasClass('active'), 'target:' + target + ', element' + element)
deferred.resolve()
})
$content.scrollTop(scrollHeight)
return deferred.promise()
}

$.when(testElementIsActiveAfterScroll('#a-1', '#div-1'))
.then(function () { return testElementIsActiveAfterScroll('#a-2', '#div-2') })
.then(function () { done() })
})

QUnit.test('should add the active class correctly when there are nested elements at 0 scroll offset', function (assert) {
assert.expect(6)
var times = 0
Expand Down Expand Up @@ -246,6 +283,46 @@ $(function () {
testActiveElements()
})

QUnit.test('should add the active class correctly when there are nested elements (nav markup)', function (assert) {
assert.expect(6)
var times = 0
var done = assert.async()
var navbarHtml = '<nav id="navigation" class="navbar">'
+ '<nav class="nav">'
+ '<a id="a-1" class="nav-link" href="#div-1">div 1</a>'
+ '<nav>'
+ '<a id="a-2" class="nav-link" href="#div-2">div 2</a>'
+ '</nav>'
+ '</nav>'
+ '</nav>'

var contentHtml = '<div class="content" style="position: absolute; top: 0px; overflow: auto; height: 50px">'
+ '<div id="div-1" style="padding: 0; margin: 0">'
+ '<div id="div-2" style="height: 200px; padding: 0; margin: 0">div 2</div>'
+ '</div>'
+ '</div>'

$(navbarHtml).appendTo('#qunit-fixture')

var $content = $(contentHtml)
.appendTo('#qunit-fixture')
.bootstrapScrollspy({ offset: 0, target: '#navigation' })

function testActiveElements() {
if (++times > 3) { return done() }

$content.one('scroll', function () {
assert.ok($('#a-1').hasClass('active'), 'nav item for outer element has "active" class')
assert.ok($('#a-2').hasClass('active'), 'nav item for inner element has "active" class')
testActiveElements()
})

$content.scrollTop($content.scrollTop() + 10)
}

testActiveElements()
})

QUnit.test('should clear selection if above the first section', function (assert) {
assert.expect(3)
var done = assert.async()
Expand Down
Loading