Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused scss variables #21579

Merged
merged 4 commits into from
Jan 16, 2017
Merged

Remove unused scss variables #21579

merged 4 commits into from
Jan 16, 2017

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented Jan 6, 2017

Fixes #21551

Remove unused scss variables mentioned in #21551 and a few more.

@Quy
Copy link

Quy commented Jan 6, 2017

On this page too. Thanks.
https://v4-alpha.getbootstrap.com/layout/overview/

@pvdlg
Copy link
Contributor Author

pvdlg commented Jan 6, 2017

Done. Good catch @Quy !

@mdo mdo added this to the v4.0.0-beta milestone Jan 6, 2017
@@ -851,7 +832,6 @@ $progress-height: 1rem !default;
$progress-font-size: .75rem !default;
$progress-bg: $gray-lighter !default;
$progress-border-radius: $border-radius !default;
$progress-box-shadow: inset 0 .1rem .1rem rgba($black,.1) !default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can remain; I'll need to add a conditional shadow to the .progress to make use of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@pvdlg
Copy link
Contributor Author

pvdlg commented Jan 6, 2017

Re-added $progress-box-shadow

@mdo mdo merged commit a3bc607 into twbs:v4-dev Jan 16, 2017
@mdo mdo mentioned this pull request Jan 16, 2017
@pvdlg pvdlg deleted the remove-unused-variables branch January 16, 2017 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants