Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated flex comments + other small changes #21432

Merged
merged 3 commits into from
Dec 25, 2016
Merged

Remove outdated flex comments + other small changes #21432

merged 3 commits into from
Dec 25, 2016

Conversation

Starsam80
Copy link
Contributor

First commit just removes some stuff I found that related to the flexbox change. When I searched for these files, I couldn't find any references to them, so I believe that is safe to remove them.

The second commit cleans up _spacing.scss a little bit:

  • Adjust whitespace a little bit
  • Use a single @include media-breakpoint-up for all the classes
  • Rearrange the margin: auto classes so it's the same pattern (all, top, right, bottom, left, x, y)

The third commit changes the width and height classes to use variables, allowing people to add their own values if needed.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 25, 2016
@mdo mdo merged commit c2e5eb1 into twbs:v4-dev Dec 25, 2016
@mdo mdo mentioned this pull request Dec 25, 2016
@Starsam80 Starsam80 deleted the stuff branch December 25, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants