Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'system-ui' to font stack. #21356

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Add 'system-ui' to font stack. #21356

merged 1 commit into from
Dec 20, 2016

Conversation

bardiharborow
Copy link
Member

Fixes #21354.

@klimashkin
Copy link

@bardiharborow Why system-ui is not first in list, why it should be after -apple-system?

@wolfy1339
Copy link
Contributor

wolfy1339 commented Apr 19, 2017

@klimashkin This was reverted in #22377 because​ it was causing issues

@GrimLink
Copy link

GrimLink commented Dec 5, 2017

@mdo I don't understand why system-ui i has been removed from the stack.
Instead move the "Segoe UI" before the value in the stack instead.

Maybe like this:
$font-family-sans-serif: -apple-system, "Segoe UI", system-ui, ... !default;
This way we can still have the advantage of the system-ui without having the Windows bug.
Also BlinkMacSystemFont is an older version of system-ui for chrome on OSX.
Since Chrome 56 we should use the newer version, system-ui

@mdo
Copy link
Member

mdo commented Dec 12, 2017

@GrimLink Read #22328 for the background on why it was reverted outright. We didn't test, as far as I know, changing the font stack's order, but if you have a demo of it fixing the problems listed in the referenced issue, please open a new issue to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants