-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variables for transitions #21345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't have to close the old PR, git push --force
does exist. If you fix the 2 notes I made, LGTM.
First time doing a GitHub review. No idea how this is going to work
@@ -15,7 +15,7 @@ | |||
user-select: none; | |||
border: $input-btn-border-width solid transparent; | |||
@include button-size($btn-padding-y, $btn-padding-x, $font-size-base, $btn-border-radius); | |||
@include transition(all .2s ease-in-out); | |||
@include transition($transition-base); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be its own variable: $btn-transition
@@ -16,7 +16,7 @@ | |||
background-color: $thumbnail-bg; | |||
border: $thumbnail-border-width solid $thumbnail-border-color; | |||
@include border-radius($thumbnail-border-radius); | |||
@include transition(all .2s ease-in-out); | |||
@include transition($transition-base); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be its own variable: $thumbnail-transition
@tomlutzenberger Again as stated way back in issue #21266 & #21334
The reason being is that this could limit the number of variables to a standard set. Bootstrap is not created to offer "all" solutions but a couple. It's just a framework. Not a full huge behemoth framework that does everything. IMO. |
Yes, I have to admit that I haven't thought of the forced push. |
Revision of #21334
See also #21266