Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .col-xs to .col + some other cleanup #21222

Merged
merged 2 commits into from
Nov 28, 2016
Merged

Rename .col-xs to .col + some other cleanup #21222

merged 2 commits into from
Nov 28, 2016

Conversation

Starsam80
Copy link
Contributor

I changed lots of little stuff but the main points are

  • Use breakpoint-min instead of a counter: This cleans up the code quite a bit and makes it more readable.
  • Add > .col, to the .no-gutters class. Without this, > [class*="col-"] wouldn't match .col, and changing it to something like > [class*="col"] would make it match .collapse and more.
  • Rename .col-xs and .col-xs-auto to .col and .col-auto
  • Update some documentation to use new classes that weren't changed before
  • Fixed a minor bug where even though $enable-flex was false, it would still produce parts of flex classes.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 28, 2016
@mdo
Copy link
Member

mdo commented Nov 28, 2016

<3<3<3

@mdo mdo merged commit 08e36a3 into twbs:v4-dev Nov 28, 2016
@mdo mdo mentioned this pull request Nov 28, 2016
@Starsam80 Starsam80 deleted the cleanup-grid branch November 28, 2016 06:48
@fchiumeo fchiumeo mentioned this pull request Jan 4, 2017
@einfallstoll
Copy link

einfallstoll commented Jan 16, 2017

Wouldn't it make more sense to come up with a table like this:

Name Tiny* Extra small Small Medium Large
Size <576px ≥576px ≥768px ≥992px ≥1200px
Prefix .col- .col-xs- .col-sm- .col-md- .col-lg-

* I actually don't have a better name to come up with. (Does it even make sense to be that small? I mean my smartphone is huge)

This would be backward-compatible while still implementing this "tiny .col-"-class.

And another question: Do you really call ≥1200px "extra large"? This ain't half of my screen. Extra large is more like ≥1400px or ≥1500px to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants