Rename .flex-xs-* and .flex-items-xs-* to .flex-* and .flex-items-*
#21218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit just cleans up the formating of _flex.scss by changing it so that it uses a single `@include media-breakpoint-up` instead of multiple. It also aligns all of the CSS properties so it looks a bit nicer.
|
Awesome, thanks <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same approach as #21217, but this time I changed the formatting of
_flex.scssa little bit so it was more easier to add@if {...} @else {...}.The only remaining
xsclasses after this PR are:.col-xs.col-xs-auto.navbar-toggleable-xs.hidden-xs-up.hidden-xs-downI plan on doing something about
.col-xs(-auto)without affecting this (.colwouldn't match) but that takes a bit more work..hidden-xs-(up|down)seem like they have a naming convention going on, so changing one may break it. I'll leave that for someone else to decide.