Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap-grid.scss to include box-sizing and responsive changes #21202

Merged
merged 1 commit into from
Nov 26, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 26, 2016

This fixes #17982 I think—judging by the issue's screenshots, it was missing some box-sizing. Alongside that, since this is a responsive grid, I figured we'd need those responsive changes from Reboot as well.

/cc @Restuta

@mdo
Copy link
Member Author

mdo commented Nov 26, 2016

Looks like it works: https://jsbin.com/bicamu/edit?output

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 26, 2016
@mdo mdo merged commit 308bc77 into v4-dev Nov 26, 2016
@mdo mdo mentioned this pull request Nov 26, 2016
@mdo mdo deleted the v4-grid-box-sizing branch November 26, 2016 07:04
@Restuta
Copy link

Restuta commented Nov 26, 2016

@mdo thanks, would be happy to test it, is it published to bower?

@mdo
Copy link
Member Author

mdo commented Dec 2, 2016

You can point any Bower package to a particular SHA or branch I think. We don't have this release published anywhere else yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants