Travis build infrastructure refresh. #21108
Conversation
| @@ -361,7 +358,7 @@ module.exports = function (grunt) { | |||
| if (typeof process.env.SAUCE_ACCESS_KEY !== 'undefined' && | |||
| // Skip Sauce if running a different subset of the test suite | |||
| runSubset('sauce-js-unit')) { | |||
| testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs', 'exec:upload-preview']); | |||
| testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs']); | |||
| @@ -361,7 +358,7 @@ module.exports = function (grunt) { | |||
| if (typeof process.env.SAUCE_ACCESS_KEY !== 'undefined' && | |||
| // Skip Sauce if running a different subset of the test suite | |||
| runSubset('sauce-js-unit')) { | |||
| testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs', 'exec:upload-preview']); | |||
| testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs']); | |||
|
@cvrebert Wanna take a look at this and let me know what you think? <3 |
| - npm install | ||
| - npm install --only=development | ||
| after_success: | ||
| - grunt/upload-preview.sh |
There was a problem hiding this comment.
This was where it was in the Gruntfile so that it would only run only when the docs had actually been built, and so it would only run once (instead of 3x on account of the build matrix).
There was a problem hiding this comment.
Ah. I was mainly moving this out of the Gruntfile as part of the whole move to npm scripts, but I forgot about the whole build matrix issue. I've added a condition on the front. I can move back to the Gruntfile if you really don't like it here.
| matrix: | ||
| fast_finish: true |
There was a problem hiding this comment.
fast_finish only seems to have meaning where there are allowed failures.
| - cp grunt/npm-shrinkwrap.json ./ | ||
| - npm install | ||
| - npm install --only=development |
There was a problem hiding this comment.
If we ever sort out the "use ES6 imports for our deps" issue, then we'll need the non-dev dependencies (jQuery, Tether, etc.)
See #18754. BrowserStack seems like our best option IMHO. |
| @@ -361,7 +358,7 @@ module.exports = function (grunt) { | |||
| if (typeof process.env.SAUCE_ACCESS_KEY !== 'undefined' && | |||
| // Skip Sauce if running a different subset of the test suite | |||
| runSubset('sauce-js-unit')) { | |||
| testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs', 'exec:upload-preview']); | |||
| testSubtasks = testSubtasks.concat(['dist', 'docs-css', 'docs-js', 'clean:docs', 'copy:docs']); | |||
Ah. I saw that but I wasn't sure if it was still on the table. |
Resolves #17163. Ubuntu Trusty containers are now available on Travis, removing the last obstacle stopping us moving to the container based environment. This cuts build times by about 15 seconds.
Regarding the other changes: Ruby 2.3.1 comes preinstalled on the new images, so I have removed the install directive. The npm install directive has been made conditional as only the Node 4.x environment will have npm 2.x.
--retry=3has been added to the bundler command to bring it in line with Travis' default and to provide greater network stability.NPM_CONFIG_PROGRESS="false"has been removed as npm/npm#11283 seems to be fixed. Git--depthhas been lowered.Coming soon in another PR, is switching to using the Travis apt addon to download the Google Cloud SDK (blocked on travis-ci/apt-package-safelist#3515) and switching to using the Travis sauce_connect addon rather than using grunt-saucelabs (blocked on further investigation).