Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/omit xs from grid #21086

Merged
merged 2 commits into from
Nov 17, 2016
Merged

Feature/omit xs from grid #21086

merged 2 commits into from
Nov 17, 2016

Conversation

ETNOL
Copy link

@ETNOL ETNOL commented Nov 4, 2016

Everything changed in the diff LGTM. Hard to judge if there was anything else that should have been updated and was missed. I checked for any "push-xs-", "pull-xs-", "offset-xs-", and "col-xs-" classes. They all appear to be correctly updated to omit "xs" now.

@wolfy1339
Copy link
Contributor

Please exclude dist files

The new breakpiont-limited class pattern is to omit the breakpoint size when using the lowest size eg. col-xs-12 to col-12. This commit implements this pattern to the grid system.
@ETNOL ETNOL force-pushed the feature/OmitXsFromGrid branch from d1387d6 to 9402be4 Compare November 4, 2016 16:48
@ETNOL
Copy link
Author

ETNOL commented Nov 4, 2016

@wolfy1339 Done

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 17, 2016
@mdo mdo merged commit 6910516 into twbs:v4-dev Nov 17, 2016
@mdo
Copy link
Member

mdo commented Nov 17, 2016

This is huge, thanks so much! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants